Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk container start: add subnet/gateway flags #17934

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

r-vasquez
Copy link
Contributor

To let the user select their network configuration and avoid conflicts.

Fixes #9008

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • rpk container start: You can now select the subnet and gateway to create your 'redpanda' network.

@r-vasquez r-vasquez force-pushed the container-subnet-flags branch 2 times, most recently from 42b9faf to c07d030 Compare April 24, 2024 17:57
@r-vasquez r-vasquez marked this pull request as ready for review April 24, 2024 17:57
@r-vasquez r-vasquez force-pushed the container-subnet-flags branch 2 times, most recently from 71713ae to dd30110 Compare April 24, 2024 18:07
gene-redpanda
gene-redpanda previously approved these changes Apr 24, 2024
Let the user select their network configuration.

Fixes redpanda-data#9008
@r-vasquez r-vasquez force-pushed the container-subnet-flags branch from 1d460c0 to b124534 Compare April 24, 2024 18:33
@r-vasquez r-vasquez requested a review from gene-redpanda April 24, 2024 19:06
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/48231#018f119a-b691-4801-8131-9387f8e2dbb8:

"rptest.tests.rbac_upgrade_test.UpgradeMigrationCreatingDefaultRole.test_rbac_migration"

@vbotbuildovich
Copy link
Collaborator

@r-vasquez
Copy link
Contributor Author

Failures are #18033

@twmb twmb merged commit 86004c0 into redpanda-data:dev Apr 25, 2024
17 of 22 checks passed
@r-vasquez r-vasquez deleted the container-subnet-flags branch April 25, 2024 23:33
@r-vasquez
Copy link
Contributor Author

/backport v24.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpk container start failed due to subnet conflict
4 participants