-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global dependencies from test_utils/random #17352
Conversation
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Test utils is a global library, but had lots of bits from modules (e.g. security, model, etc...). This resulted in a lot of implicit dependencies. This commit splits it and includes the specializations in each module. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
636eb79
to
623cdc5
Compare
Force-push: missed one in release builds. |
@@ -11,8 +11,6 @@ | |||
|
|||
#include "base/likely.h" | |||
#include "base/vlog.h" | |||
#include "cluster/cluster_utils.h" | |||
#include "cluster/topic_table.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6cf8-4f0a-4251-9690-223169f04e6b ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6d0a-6f8f-4198-a72d-f2ac09cee060 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6d0a-6f8a-4097-b1ea-6c25bec4ee32 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46671#018e6d0a-6f8c-4f94-a9c8-a7680eb4ec16 |
CI failure #14425 |
split up test_utils header for greater good
Backports Required
Release Notes