Skip to content

cloud_storage: consistent handling of booleans in topic config properties #6772

Open
@jcsp

Description

Setting remote.write to True is accepted but does not take effect:

root@231067b69493:/# /home/vectorized/redpanda/vbuild/debug/clang/dist/local/redpanda/bin/rpk --brokers docker-rp-1:9092,docker-rp-3:9092,docker-rp-2:9092 topic alter-config test-si-topic-with-retention-altered --set redpanda.remote.write=True 
TOPIC                                 STATUS
test-si-topic-with-retention-altered  OK

root@231067b69493:/# /home/vectorized/redpanda/vbuild/debug/clang/dist/local/redpanda/bin/rpk --brokers docker-rp-1:9092,docker-rp-3:9092,docker-rp-2:9092 topic describe test-si-topic-with-retention-altered
SUMMARY
=======
NAME        test-si-topic-with-retention-altered
PARTITIONS  1
REPLICAS    1

CONFIGS
=======
KEY                     VALUE                          SOURCE
...
redpanda.remote.write   false                          DYNAMIC_TOPIC_CONFIG

We should make all our boolean inputs take as consistent set of value values. I think we have to support "yes" and "no" for backward compat as those are already in there. We should also accept case-insensitive true/false strings.

JIRA Link: CORE-1044

Metadata

Assignees

No one assigned

    Labels

    area/cloud-storageShadow indexing subsystemkind/bugSomething isn't workingsev/lowBugs which are non-functional paper cuts, e.g. typos, issues in log messages

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions