rpk profile: change MoveProfileToFront to **config.RpkProfile

For the same reasons as the prior commit.

Only `rpk profile create` actually modify the profile fields after
the move, and only in `rpk profile create --from-cloud`.

src/go/rpk/pkg/cli/profile/create.go

@@ -284,7 +284,7 @@ func CreateFlow(
 		// * The user's prior profile was NOT the rpk-cloud profile
 		// * We are switching to the existing rpk-cloud profile and updating the values
 		fmt.Printf("Switched to existing %q profile and updated it to talk to cluster %q.\n", RpkCloudProfileName, o.FullName())
-		priorAuth, currentAuth := yAct.MoveProfileToFront(p)
+		priorAuth, currentAuth := yAct.MoveProfileToFront(&p)
 		config.MaybePrintAuthSwitchMessage(priorAuth, currentAuth)
 
 	case fromCloud != "" && name == RpkCloudProfileName:

src/go/rpk/pkg/cli/profile/rename.go

@@ -44,7 +44,7 @@ func newRenameToCommand(fs afero.Fs, p *config.Params) *cobra.Command {
 			}
 			p.Name = to
 			y.CurrentProfile = to
-			priorAuth, currentAuth := y.MoveProfileToFront(p)
+			priorAuth, currentAuth := y.MoveProfileToFront(&p)
 			err = y.Write(fs)
 			out.MaybeDieErr(err)
 			fmt.Printf("Renamed current profile to %q.\n", to)

src/go/rpk/pkg/cli/profile/use.go

@@ -38,7 +38,7 @@ func newUseCommand(fs afero.Fs, p *config.Params) *cobra.Command {
 			if p == nil {
 				out.Die("profile %q does not exist", name)
 			}
-			priorAuth, currentAuth := y.MoveProfileToFront(p)
+			priorAuth, currentAuth := y.MoveProfileToFront(&p)
 
 			err = y.Write(fs)
 			out.MaybeDieErr(err)

src/go/rpk/pkg/config/rpk_yaml.go

@@ -200,22 +200,23 @@ func (y *RpkYaml) PushProfile(p RpkProfile) (priorAuth, currentAuth *RpkCloudAut
 }
 
 // MoveProfileToFront moves the given profile to the front of the list.
-func (y *RpkYaml) MoveProfileToFront(p *RpkProfile) (priorAuth, currentAuth *RpkCloudAuth) {
+func (y *RpkYaml) MoveProfileToFront(p **RpkProfile) (priorAuth, currentAuth *RpkCloudAuth) {
 	priorAuth = y.CurrentAuth()
-	reordered := []RpkProfile{*p}
+	reordered := []RpkProfile{**p}
 	for i := range y.Profiles {
-		if &y.Profiles[i] == p {
+		if &y.Profiles[i] == *p {
 			continue
 		}
 		reordered = append(reordered, y.Profiles[i])
 	}
 	y.Profiles = reordered
-	y.CurrentProfile = p.Name
+	*p = &reordered[0]
+	y.CurrentProfile = (*p).Name
 
 	// If this is a cloud profile, we switch the auth as well.
-	if p.FromCloud {
-		y.CurrentCloudAuthOrgID = p.CloudCluster.AuthOrgID
-		y.CurrentCloudAuthKind = p.CloudCluster.AuthKind
+	if (*p).FromCloud {
+		y.CurrentCloudAuthOrgID = (*p).CloudCluster.AuthOrgID
+		y.CurrentCloudAuthKind = (*p).CloudCluster.AuthKind
 	}
 	currentAuth = y.CurrentAuth()
 	return priorAuth, currentAuth