print out CEL config warnings #962

alenkacz · 2025-07-03T06:31:46Z

This should make the warnings more visible and such cases easier to debug.

jan-g · 2025-07-03T08:47:25Z

Absolutely spot on. I always intended to have these emitted, it just slipped off the radar.

chrisseto · 2025-07-08T18:22:58Z

operator/internal/controller/redpanda/redpanda_controller.go

 		return nil, errors.WithStack(err)
 	}

+	if conf.Warn() != nil {


Could we instead make this an additional return on Reify? It's much less likely to be forgotten in the case a refactor and it avoids any issues that may pop up due to internal mutability.

chrisseto · 2025-07-08T18:38:15Z

operator/internal/controller/redpanda/redpanda_controller.go

+		logger := log.FromContext(ctx).WithName(fmt.Sprintf("ClusterReconciler[%T].clusterConfigFor", *rp))
+		logger.V(log.InfoLevel).Info("warning during configuration processing", warn)
+
+		r.EventRecorder.Eventf(rp, "Warning", redpandav1alpha2.EventSeverityError, warn)


Updating the logger name isn't particularly useful IMO. It's just more text to scroll right of to get the useful part of the log. we'll be searching the log message to find this line if need be.

Additional args should come inkey, value pairs.

I'd also vote to drop the event emission for now. I do think this is a valuable thing to emit as an event but as is this event will be unintelligible and I'm not familiar enough with the event recording interface to recommend a better direction.

Suggested change

logger := log.FromContext(ctx).WithName(fmt.Sprintf("ClusterReconciler[%T].clusterConfigFor", *rp))

logger.V(log.InfoLevel).Info("warning during configuration processing", warn)

r.EventRecorder.Eventf(rp, "Warning", redpandav1alpha2.EventSeverityError, warn)

logger := log.FromContext(ctx)

logger.V(log.InfoLevel).Info("cluster config reification produced warnings", "warnings", warnings)

chrisseto · 2025-07-08T18:39:18Z

This will need to be backported to release/v25.1.x only :D

github-actions · 2025-07-14T02:12:58Z