Skip to content

Commit

Permalink
Fix helm default values
Browse files Browse the repository at this point in the history
- fixed typo in granularity (singular required)
- removed unknown path in prom exporter config
- fixed Service and ServiceMonitor port name
  • Loading branch information
amuraru committed Mar 15, 2021
1 parent 75daf70 commit 7152855
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions charts/kminion/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
targetPort: http
targetPort: metrics
protocol: TCP
name: http
name: metrics
selector:
{{- include "kminion.selectorLabels" . | nindent 4 }}
3 changes: 2 additions & 1 deletion charts/kminion/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ spec:
{{- include "kminion.labels" . | nindent 4}}
endpoints:
- port: metrics
path: /metrics
honorLabels: {{ .Values.serviceMonitor.honorLabels }}
{{- end }}
{{- end }}
4 changes: 1 addition & 3 deletions charts/kminion/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ kminion:
# # Granularity can be per topic or per partition. If you want to reduce the number of exported metric series and
# # you aren't interested in per partition lags you could choose "topic" where all partition lags will be summed
# # and only topic lags will be exported.
# granularity: partitions
# granularity: partition
# # AllowedGroups are regex strings of group ids that shall be exported
# # You can specify allowed groups by providing literals like "my-consumergroup-name" or by providing regex expressions
# # like "/internal-.*/".
Expand Down Expand Up @@ -193,8 +193,6 @@ kminion:
# host: ""
# # Port that shall be used to bind the HTTP server on
# port: 8080
# # Path to serve the Prometheus metrics
# path: "/metrics"
#
# logger:
# # Level is a logging priority. Higher levels are more important. Valid values are: debug, info, warn, error, fatal, panic
Expand Down

0 comments on commit 7152855

Please sign in to comment.