feat(kminion): add opt-in topologySpreadConstraints to deployment and daemonset - #1754
Merged
RafalKorepta merged 1 commit intoJun 25, 2026
Conversation
|
|
somaz94
marked this pull request as ready for review
June 23, 2026 09:40
somaz94
requested review from
JakeSCahill,
RafalKorepta,
andrewstucki,
chrisseto and
hidalgopl
as code owners
June 23, 2026 09:40
RafalKorepta
approved these changes
Jun 23, 2026
hidalgopl
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
topologySpreadConstraintsfield to the kminion chart's Deployment and DaemonSet, mirroring the existing knob in the siblingconnectchart (charts/connect). It defaults to[], so the rendered output is unchanged unless a user sets it.This rounds out kminion's scheduling knobs (it already exposes
nodeSelector,affinityandtolerations).Validation (run locally):
ct lint --charts charts/kminion: all charts linted successfullyactionlint: cleanhelm templatewith default values: field is absent, render is byte-identical to beforehelm templatewith a constraint set: renders correctly on both the Deployment and the DaemonSetrelated: #1040