console: consistently set .Namespace
#1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit objects produced from the console helm chart would inconsistently set `namespace`. This isn't particularly noticeable as `kubectl` and `helm` often set namespace transparently but it can cause issues when using other tooling. This commit sets namespace on all objects it was set on, adds a test assertion that namespace is present across all objects, and removes usages of `extraInitContainers` from tests as they generated invalid manifests.
RafalKorepta
approved these changes
Oct 30, 2024
|
Hmmmm, there's an interesting CI failure. GoHelmEquivalence fails because the console chart isn't updated in tests which isn't possible because we need to merge the change to get a release of console.... |
|
Could we disable console in this test, release and then re-enable that test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit objects produced from the console helm chart would inconsistently set
namespace. This isn't particularly noticeable askubectlandhelmoften set namespace transparently but it can cause issues when using other tooling.This commit sets namespace on all objects it was set on, adds a test assertion that namespace is present across all objects, and removes usages of
extraInitContainersfrom tests as they generated invalid manifests.