-
Notifications
You must be signed in to change notification settings - Fork 47
Fix duplicate lines #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate lines #1370
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation file modules/migrate/pages/console-v3.adoc was updated to remove a duplicated sentence, clarify that OIDC impersonation ignores roleBindings and that access is controlled by ACLs/RBAC, and add explicit instructions to provision users in Redpanda and grant permissions. The “Migrate Redpanda Console roles to Redpanda ACLs” subsection was revised to mention impersonation and include the provisioning instruction. UI elements (button bars and editors) were added to the migration tool section using two ++++ blocks. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/migrate/pages/console-v3.adoc (1)
215-217: Impersonation guidance looks correct; add refs for “provision and grant permissions.”The clarification is good. Consider adding direct cross-references so readers know where to provision users and assign permissions.
Apply this minimal tweak:
-You must provision your users in Redpanda and grant them the appropriate permissions. +You must provision your users in Redpanda and grant them the appropriate permissions. See xref:manage:security/authentication.adoc[] and xref:manage:security/authorization/index.adoc[].
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/migrate/pages/console-v3.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
micheleRP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This pull request makes minor improvements to the documentation in
console-v3.adocfor migrating from Redpanda Console v2 to v3. The changes clarify the instructions for migrating user roles and permissions, especially when using impersonation in v3.roleBindingsand impersonation, making it clear that users must be provisioned and granted permissions in Redpanda when using impersonation in v3.Page previews
Checks