-
Notifications
You must be signed in to change notification settings - Fork 47
DOC-1686 single source auto_create_topics_enabled #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1686 single source auto_create_topics_enabled #1361
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds a Cloud-specific note to the topic creation docs indicating a 40,000-topics-per-cluster limit under env-cloud. Introduces a new documented cluster property, auto_create_topics_enabled, describing automatic topic creation behavior, default visibility differences for Cloud vs. non-Cloud builds, and that it doesn’t require restart. Adds a note that cluster_id is read-only in Redpanda Cloud. All changes are documentation-only; no code or behavior changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/reference/pages/properties/cluster-properties.adoc (1)
311-330: Single‑source block looks good; tighten language and explicitly state Cloud support (include Serverless).
- File: modules/reference/pages/properties/cluster-properties.adoc (lines ~311–330)
- Change sentence to: "Allows automatic topic creation."
- Add an env-cloud note (ifdef::env-cloud[]) that states: "NOTE: Not supported on Redpanda Cloud (Serverless, BYOC, Dedicated). Create topics explicitly (for example, with
rpk topic create)."- Add Related topics: xref:develop:config-topics.adoc#create-a-topic[Create a topic]
- Verified: default for self‑managed = false; tag block is single‑sourced (no include:: found). Repo has example configs that set this true (helm chart, rpk-start, deployment docs) — those are examples and need no change unless you want consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
modules/develop/pages/config-topics.adoc(1 hunks)modules/reference/pages/properties/cluster-properties.adoc(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (1)
modules/develop/pages/config-topics.adoc (1)
25-26: Replace the hard "40,000 topics" statement with partition-quota guidanceFile: modules/develop/pages/config-topics.adoc (lines 25–26)
Redpanda Cloud enforces cluster-level logical partition quotas (not a single fixed "topics per cluster" cap). Serverless clusters have a documented 5,000 logical-partition limit; BYOC/Dedicated limits are tier-dependent. Internal topics/partitions count toward the same quota. Replace the line with a short NOTE describing this and how to compute a topics cap and to contact Support to increase limits.
Suggested replacement:
-Redpanda Cloud supports 40,000 topics per cluster. +NOTE: Redpanda Cloud does not publish a fixed "topics per cluster" limit. Topic capacity is governed by the cluster's logical-partition quota (partition quota ÷ partitions per topic). Serverless clusters have a documented limit of 5,000 logical partitions; BYOC/Dedicated limits vary by tier. Internal topics count toward the partition total. Contact Redpanda Support to request higher capacity.Likely an incorrect or invalid review comment.
Description
Related to redpanda-data/cloud-docs#418:
config-topics.adocfile.auto_create_topics_enabledcluster propertyResolves https://redpandadata.atlassian.net/browse/DOC-1686
Review deadline:
Page previews
Checks