Skip to content

Conversation

@micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Sep 19, 2025

Description

Related to redpanda-data/cloud-docs#418:

  • State that Redpanda Cloud supports up to 40,000 topics per cluster in the config-topics.adoc file.
  • Add single sourcing for auto_create_topics_enabled cluster property

Resolves https://redpandadata.atlassian.net/browse/DOC-1686
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner September 19, 2025 16:14
@netlify
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 30c38be
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/68d2d762b74bfe00087fe875
😎 Deploy Preview https://deploy-preview-1361--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Adds a Cloud-specific note to the topic creation docs indicating a 40,000-topics-per-cluster limit under env-cloud. Introduces a new documented cluster property, auto_create_topics_enabled, describing automatic topic creation behavior, default visibility differences for Cloud vs. non-Cloud builds, and that it doesn’t require restart. Adds a note that cluster_id is read-only in Redpanda Cloud. All changes are documentation-only; no code or behavior changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • mattschumpert
  • deniscoady
  • weeco

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning The PR includes edits outside the linked issue's scope: a new informational line in config-topics.adoc stating "Redpanda Cloud supports 40,000 topics per cluster" and an added note to the cluster_id property; these changes are unrelated to the single-source auto_create_topics_enabled objective. Please remove or move the unrelated edits into separate PRs or update this PR description to explicitly justify and link the related tickets for the 40,000-topics statement and the cluster_id note, and include page previews for those edits if they remain in this PR so reviewers can evaluate them together.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title "DOC-1686 single source auto_create_topics_enabled" clearly references the Jira ticket and succinctly summarizes the primary change (creating a single source for the auto_create_topics_enabled property), so it matches the changes in the PR and is specific enough for history scanning.
Linked Issues Check ✅ Passed The PR implements the linked issue DOC-1686 by adding a single-sourced cluster property auto_create_topics_enabled (tag::auto_create_topics_enabled[] markers and the property declaration are present) and documents its behavior, default visibility, and Cloud restrictions, which satisfies the linked issue's objective.
Description Check ✅ Passed The PR description follows the repository template by including the "Resolves" Jira link, a concise summary of the changes (single-sourcing auto_create_topics_enabled and the 40,000-topic Cloud note), and the Checks section, so it is sufficient for reviewers; however the Page previews section contains no preview URLs and the Review deadline field is left blank.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
modules/reference/pages/properties/cluster-properties.adoc (1)

311-330: Single‑source block looks good; tighten language and explicitly state Cloud support (include Serverless).

  • File: modules/reference/pages/properties/cluster-properties.adoc (lines ~311–330)
  • Change sentence to: "Allows automatic topic creation."
  • Add an env-cloud note (ifdef::env-cloud[]) that states: "NOTE: Not supported on Redpanda Cloud (Serverless, BYOC, Dedicated). Create topics explicitly (for example, with rpk topic create)."
  • Add Related topics: xref:develop:config-topics.adoc#create-a-topic[Create a topic]
  • Verified: default for self‑managed = false; tag block is single‑sourced (no include:: found). Repo has example configs that set this true (helm chart, rpk-start, deployment docs) — those are examples and need no change unless you want consistency.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0630114 and 61e3a19.

📒 Files selected for processing (2)
  • modules/develop/pages/config-topics.adoc (1 hunks)
  • modules/reference/pages/properties/cluster-properties.adoc (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - redpanda-docs-preview
  • GitHub Check: Header rules - redpanda-docs-preview
  • GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (1)
modules/develop/pages/config-topics.adoc (1)

25-26: Replace the hard "40,000 topics" statement with partition-quota guidance

File: modules/develop/pages/config-topics.adoc (lines 25–26)

Redpanda Cloud enforces cluster-level logical partition quotas (not a single fixed "topics per cluster" cap). Serverless clusters have a documented 5,000 logical-partition limit; BYOC/Dedicated limits are tier-dependent. Internal topics/partitions count toward the same quota. Replace the line with a short NOTE describing this and how to compute a topics cap and to contact Support to increase limits.

Suggested replacement:

-Redpanda Cloud supports 40,000 topics per cluster.
+NOTE: Redpanda Cloud does not publish a fixed "topics per cluster" limit. Topic capacity is governed by the cluster's logical-partition quota (partition quota ÷ partitions per topic). Serverless clusters have a documented limit of 5,000 logical partitions; BYOC/Dedicated limits vary by tier. Internal topics count toward the partition total. Contact Redpanda Support to request higher capacity.

Likely an incorrect or invalid review comment.

@micheleRP micheleRP merged commit 1cf0117 into main Sep 23, 2025
7 checks passed
@micheleRP micheleRP deleted the DOC-1686-single-source-auto_create_topics_enabled branch September 23, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants