-
Notifications
You must be signed in to change notification settings - Fork 47
DOC-1292 Move Migrate section to the top level in nav tree #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe documentation navigation was restructured by moving the "Migrate" section from under the "Upgrade" hierarchy to a top-level position in the navigation tree. All related cross-reference links throughout the documentation were updated to reflect the new path for migration documents. Page alias metadata was added to the migration documents to support backward compatibility with old paths. The navigation structure and document references now consistently use the new top-level "migrate" path, and the operator-specific migration entry was removed from the navigation. No changes were made to exported or public code entities. Assessment against linked issues
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
modules/upgrade/pages/deprecated/index.adoc (1)
4-4:⚠️ Potential issueVerify
:page-aliases:entry for Kubernetes operator migration
The aliasupgrade:migrate/kubernetes/operator.adocdoesn’t match any known file in themigrate/kubernetesdirectory (we expecthelm-to-operator.adocorstrimzi.adoc). This may lead to broken links. Please confirm or correct this alias.
🧹 Nitpick comments (1)
modules/get-started/pages/release-notes/redpanda.adoc (1)
57-57: Cross-reference updated to top-level migrate path
Thexref:was correctly switched fromupgrade:migrate/console-v3.adoc[]tomigrate:console-v3.adoc[].Consider adding descriptive link text instead of an empty bracket for improved clarity, e.g.:
*Action required*: xref:migrate:console-v3.adoc[Console v3 migration guide].
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
modules/ROOT/nav.adoc(1 hunks)modules/deploy/pages/deployment-option/self-hosted/kubernetes/k-deployment-overview.adoc(1 hunks)modules/deploy/pages/deployment-option/self-hosted/manual/production/production-readiness.adoc(2 hunks)modules/get-started/pages/release-notes/redpanda.adoc(1 hunks)modules/manage/partials/whole-cluster-restore.adoc(1 hunks)modules/migrate/pages/console-v3.adoc(1 hunks)modules/migrate/pages/data-migration.adoc(1 hunks)modules/migrate/pages/index.adoc(1 hunks)modules/migrate/pages/kubernetes/helm-to-operator.adoc(1 hunks)modules/migrate/pages/kubernetes/strimzi.adoc(1 hunks)modules/shared/partials/operator-deprecation-notice.adoc(1 hunks)modules/upgrade/pages/deprecated/index.adoc(1 hunks)modules/upgrade/pages/rolling-upgrade.adoc(1 hunks)modules/upgrade/partials/incompat-changes.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (12)
modules/migrate/pages/console-v3.adoc (1)
4-4: Alias addition for backward compatibility is correct.
The new:page-aliases:entry ensures existing links underupgrade:migrate/console-v3.adoccontinue to resolve to this page.modules/migrate/pages/kubernetes/strimzi.adoc (1)
3-3: Backward-compatibility alias is accurate.
Adding:page-aliases: upgrade:migrate/kubernetes/strimzi.adocmaintains existing URLs without altering content.modules/shared/partials/operator-deprecation-notice.adoc (1)
3-3: Deprecation notice simplified appropriately.
The updated line cleanly removes migration guidance and correctly points readers to the deprecation notice underupgrade:deprecated/cluster-resource.adoc.modules/migrate/pages/kubernetes/helm-to-operator.adoc (1)
5-5: Page alias for legacy path is correct.
The:page-aliases: upgrade:migrate/kubernetes/helm-to-operator.adocattribute maintains backward compatibility without impacting existing content.modules/upgrade/partials/incompat-changes.adoc (1)
3-3: Cross-reference updated to new migrate path.
Switching fromxref:upgrade:migrate/console-v3.adoctoxref:migrate:console-v3.adocaligns with the restructured navigation and page aliases.modules/migrate/pages/index.adoc (1)
4-4: Backward-compatibility alias correctly applied
The new:page-aliases:entry ensures that references toupgrade:migrate/index.adocwill resolve to this page, preserving existing links. Syntax and path look correct.modules/migrate/pages/data-migration.adoc (1)
3-3: Page alias for upgrade path added
Includingupgrade:migrate/data-migration.adocalias maintains backward-compatibility for existing links. The comma-separated list is syntactically correct.modules/deploy/pages/deployment-option/self-hosted/kubernetes/k-deployment-overview.adoc (1)
48-48: Migration link updated for Helm-Operator guide
The cross-reference was correctly updated fromupgrade:migrate/...toxref:migrate:kubernetes/helm-to-operator.adoc[Migrate from the Redpanda Helm chart], preserving clear link text.modules/upgrade/pages/deprecated/index.adoc (1)
272-272: Cross-reference to console migration guide updated
Thexref:was correctly changed tomigrate:console-v3.adoc[], ensuring links point to the new top-level migration guide.modules/upgrade/pages/rolling-upgrade.adoc (1)
110-110:✅ Verification successful
Correct cross-reference to top-level migrate path
This update replaces the nestedupgrade:migratelink withxref:migrate:console-v3.adoc. Please confirm thatmodules/migrate/pages/console-v3.adocincludes the oldupgrade:migrate/console-v3.adocas an alias (:page-aliases:) for backward compatibility.
🏁 Script executed:
#!/bin/bash # Verify no stale upgrade:migrate console-v3 references rg -n "upgrade:migrate/console-v3.adoc"Length of output: 126
Verified alias and approved cross-reference update
modules/migrate/pages/console-v3.adocincludes:page-aliases: upgrade:migrate/console-v3.adocon line 4, ensuring backward compatibility for the updatedxref:migrate:console-v3.adoclink. No further changes needed.modules/manage/partials/whole-cluster-restore.adoc (1)
15-15:✅ Verification successful
Correct MirrorMaker 2 migration link to top-level migrate
Thexref:migrate:data-migration.adoc[MirrorMaker 2]link now aligns with the relocated section. Please verify thatmodules/migrate/pages/data-migration.adocincludes an alias for the legacyupgrade:migrate/data-migration.adocpath.
🏁 Script executed:
#!/bin/bash # Check alias metadata in the migrate data-migration page rg -n "page-aliases.*data-migration.adoc" modules/migrate/pages/data-migration.adocLength of output: 203
MirrorMaker 2 link and alias verified
Thexref:migrate:data-migration.adoc[MirrorMaker 2]reference is correct, and I’ve confirmed thatmodules/migrate/pages/data-migration.adocincludes the legacy aliasupgrade:migrate/data-migration.adoc. LGTM.modules/ROOT/nav.adoc (1)
96-100:✅ Verification successful
Promote 'Migrate' to root-level in navigation
The new* xref:migrate:index.adoc[Migrate]section correctly replaces the former nestedupgrade:migratesubsection, and the operator migration entry has been removed. Ensuremodules/migrate/pages/index.adoccontains alias metadata for the oldupgrade:migrate/index.adocpath and that there are no lingeringupgrade:migratereferences in the nav.
🏁 Script executed:
#!/bin/bash # Confirm no stale upgrade:migrate entries in navigation rg -n "upgrade:migrate" modules/ROOT/nav.adocLength of output: 45
🏁 Script executed:
#!/bin/bash # Check for any lingering “upgrade:migrate” references across the entire repo rg -n "upgrade:migrate" . # Verify alias metadata exists in the new migrate index page rg -n ":aliases:" -A 3 modules/migrate/pages/index.adocLength of output: 900
Promote 'Migrate' to root-level in navigation: Verified
- modules/ROOT/nav.adoc contains no lingering
upgrade:migratereferences.- modules/migrate/pages/index.adoc includes the required alias metadata (
:page-aliases: upgrade:migrate/index.adocon line 4).All checks pass—LGTM.
modules/deploy/pages/deployment-option/self-hosted/manual/production/production-readiness.adoc
Show resolved
Hide resolved
Feediver1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-1292
Review deadline: May 7
This pull request reorganizes and simplifies the migration documentation by moving migration-related files to a new
migratedirectory, updating references across the codebase, and adding aliases for backward compatibility. The changes aim to improve the structure and clarity of the documentation.Page previews
Checks