-
Notifications
You must be signed in to change notification settings - Fork 414
Remove mobx from quotas page #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jvorcak
wants to merge
23
commits into
master
Choose a base branch
from
refactor/remove-mobx-from-quotas-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+832
−149
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
bb62009
Remove mobx from quotas page
jvorcak 9f3f8dd
Fixes lint
jvorcak 405bdb7
Quotas: do comparisions with constants instead of numbers
jvorcak a6454a9
Fixes quotas page
jvorcak 48cd773
Fixes quotas page
jvorcak 93c2ef1
Update breadcrumbs in Quotas after mobx migration
jvorcak e99d002
wait for all quotas to load (without pagination)
jvorcak 084b0af
Decrease e2e test limit to 15
jvorcak bb4001b
Dont' run pagination tests in paralllel
jvorcak 37c9237
More quotas e2e tests
jvorcak 74ad66d
Fixes quota tests
jvorcak e104821
Fixes e2e
jvorcak d463bdf
Improved e2e tests for quotas
jvorcak ae19d34
Move schemas fetching to grpc
jvorcak b79fc88
Fixes type issueS
jvorcak 9547217
Use size constants in a e2e test
jvorcak d923cd2
Add refetch on mount
jvorcak 8154932
Run pagination tests sequentially
jvorcak 8e1a39f
Merge branch 'master' into refactor/remove-mobx-from-quotas-page
jvorcak c4812be
proto gen
jvorcak 833334f
Addressed PR comments
jvorcak 0975d8f
Merge branch 'master' into refactor/remove-mobx-from-quotas-page
jvorcak 3e1c8ee
test: print container logs on startup failure for easier CI debugging
weeco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Copyright 2024 Redpanda Data, Inc. | ||
| // | ||
| // Use of this software is governed by the Business Source License | ||
| // included in the file https://github.com/redpanda-data/redpanda/blob/dev/licenses/bsl.md | ||
| // | ||
| // As of the Change Date specified in that file, in accordance with | ||
| // the Business Source License, use of this software will be governed | ||
| // by the Apache License, Version 2.0 | ||
|
|
||
| package testutil | ||
|
|
||
| import ( | ||
| "context" | ||
| "io" | ||
| "testing" | ||
|
|
||
| "github.com/testcontainers/testcontainers-go" | ||
| ) | ||
|
|
||
| // LogContainerLogsIfFailed prints the container's logs to the test output when | ||
| // err is non-nil. This is useful for debugging container startup failures in CI, | ||
| // where the only clue is "container exited with code X" but no actual logs. | ||
| func LogContainerLogsIfFailed(ctx context.Context, t testing.TB, container testcontainers.Container, err error) { | ||
| t.Helper() | ||
|
|
||
| if err == nil || container == nil { | ||
| return | ||
| } | ||
|
|
||
| rc, logErr := container.Logs(ctx) | ||
| if logErr != nil { | ||
| t.Logf("failed to retrieve container logs after error: %v", logErr) | ||
| return | ||
| } | ||
| defer rc.Close() | ||
|
|
||
| logs, readErr := io.ReadAll(rc) | ||
| if readErr != nil { | ||
| t.Logf("failed to read container logs after error: %v", readErr) | ||
| return | ||
| } | ||
|
|
||
| t.Logf("container logs (startup error: %v):\n%s", err, string(logs)) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -158,3 +158,5 @@ dist | |
|
|
||
| # Gemini CLI | ||
| .gemini/settings.json | ||
|
|
||
| tests/**/playwright-report/ | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2026?