byovpc: Set redpanda version to use to 25.2 #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthrough
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant API as Redpanda Cloud API
participant AWS as AWS (BYO Resources)
Note over U,API: Network-first provisioning flow (new)
U->>API: POST /v1/networks (redpanda-network.json)
API-->>U: 201 Created (network_id, resource_id)
Note over U: export REDPANDA_NETWORK_ID=<network_id>
U->>API: POST /v1/clusters (redpanda-cluster.json with network_id and ARNs)
API->>AWS: Validate and wire BYO resources (ARNs, SGs, buckets)
AWS-->>API: Provisioning status
API-->>U: Cluster creation response/status
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc (1)
416-419: Env var mismatch: undefined REDPANDA_CLUSTER_RESOURCE_GROUP_NAME.Earlier you export REDPANDA_RESOURCE_GROUP_NAME, but the JSON uses REDPANDA_CLUSTER_RESOURCE_GROUP_NAME. That will expand to an empty string and break the API call.
Apply this diff:
- "redpanda_resource_group" : { "name": "${REDPANDA_CLUSTER_RESOURCE_GROUP_NAME}" }, + "redpanda_resource_group" : { "name": "${REDPANDA_RESOURCE_GROUP_NAME}" },modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc (1)
60-62: Filename inconsistency: byovnet.auto.tfvars.json vs byoc.auto.tfvars.json.You introduce the file as byovnet.auto.tfvars.json (Line 60) but the example writes byoc.auto.tfvars.json (Line 78). This will confuse users following copy/paste.
Apply this diff to make the intro match the example:
-Define a JSON file called `byovnet.auto.tfvars.json` inside the Terraform directory that contains information about the VPC. +Define a JSON file called `byoc.auto.tfvars.json` inside the Terraform directory that contains information about the VPC.Also applies to: 78-110
🧹 Nitpick comments (3)
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc (1)
452-456: Shell line continuation: stray backslash/spacing may break the command.The backslash on Line 453 appears to have trailing whitespace. In POSIX shells, a backslash must be the final character on the line.
Apply this diff:
- -H "accept: application/json"\ + -H "accept: application/json" \modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc (2)
75-110: Code fence language mislabeled.Block starts with
json but contains a bash here‑doc and shell redirection. Preferbash for accurate rendering.Apply this diff:
-```json +```bash cat > byoc.auto.tfvars.json <<EOF { ... } EOF -``` +```
420-427: Operation vs resource ID mix‑up in status check.This example says “using the operation ID” but queries /operations with ${REDPANDA_ID}, which holds the cluster resource_id from creation. Use an OPERATION_ID variable for /operations.
Apply this diff:
-Example using the operation ID returned from your create cluster command: +Example using the operation ID returned from your create cluster command: @@ -curl -X GET "https://api.redpanda.com/v1/operations/${REDPANDA_ID}" \ +export OPERATION_ID=<operation-id-from-create-cluster-response> +curl -X GET "https://api.redpanda.com/v1/operations/${OPERATION_ID}" \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc(1 hunks)modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: micheleRP
PR: redpanda-data/cloud-docs#361
File: modules/networking/pages/cloud-security-network.adoc:176-179
Timestamp: 2025-07-21T21:52:17.061Z
Learning: In Redpanda Cloud documentation, BYOVPC and BYOVNet are different product names for different cloud providers: BYOVPC is used for AWS and GCP, while BYOVNet is used for Azure. When documentation sections cover multiple cloud providers, the combined notation "BYOVPC/BYOVNet" is correct and should not be changed to use only one term.
Learnt from: micheleRP
PR: redpanda-data/cloud-docs#377
File: modules/networking/pages/dedicated/gcp/configure-psc-in-ui.adoc:35-71
Timestamp: 2025-08-07T16:36:45.111Z
Learning: In Redpanda Cloud documentation, NAT subnet and firewall rule creation commands for GCP Private Service Connect are producer-side infrastructure steps that only BYOC (Bring Your Own Cloud) customers need to perform, since they manage their own VPC. Dedicated cluster customers don't need these steps because Redpanda manages the infrastructure for them. The ifdef::env-byoc[] guard correctly hides these commands from Dedicated users.
📚 Learning: 2025-08-07T16:36:45.111Z
Learnt from: micheleRP
PR: redpanda-data/cloud-docs#377
File: modules/networking/pages/dedicated/gcp/configure-psc-in-ui.adoc:35-71
Timestamp: 2025-08-07T16:36:45.111Z
Learning: In Redpanda Cloud documentation, NAT subnet and firewall rule creation commands for GCP Private Service Connect are producer-side infrastructure steps that only BYOC (Bring Your Own Cloud) customers need to perform, since they manage their own VPC. Dedicated cluster customers don't need these steps because Redpanda manages the infrastructure for them. The ifdef::env-byoc[] guard correctly hides these commands from Dedicated users.
Applied to files:
modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc
📚 Learning: 2025-07-21T21:52:17.061Z
Learnt from: micheleRP
PR: redpanda-data/cloud-docs#361
File: modules/networking/pages/cloud-security-network.adoc:176-179
Timestamp: 2025-07-21T21:52:17.061Z
Learning: In Redpanda Cloud documentation, BYOVPC and BYOVNet are different product names for different cloud providers: BYOVPC is used for AWS and GCP, while BYOVNet is used for Azure. When documentation sections cover multiple cloud providers, the combined notation "BYOVPC/BYOVNet" is correct and should not be changed to use only one term.
Applied to files:
modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - rp-cloud
- GitHub Check: Header rules - rp-cloud
- GitHub Check: Pages changed - rp-cloud
🔇 Additional comments (2)
modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc (1)
234-235: Approve — Redpanda 25.2 confirmed supported for BYOVPC (confirmed 2025-09-15).Docs list Redpanda Core 25.2.x as supported for BYOVPC/BYOVNet and release notes reference features requiring 25.2+.
modules/get-started/pages/cluster-types/byoc/azure/vnet-azure.adoc (1)
77-77: Approve: bump to Redpanda 25.2 — GA confirmed (2025-09-15)
Redpanda 25.2 is the documented GA release supported for BYOC/BYOVNet in Redpanda Cloud as of September 15, 2025 (validated against Cloud docs, release notes, and Summer 2025 blog).
paulohtb6
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just setting the REDPANDA_VERSION variable to latest.
Bumped on that when sending the docs over to a customer to create a new BYOVPC cluster