-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-1646 RBAC in DP not supported for Serverless #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1646 RBAC in DP not supported for Serverless #403
Conversation
📝 WalkthroughWalkthroughDocumentation updates only:
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
modules/get-started/pages/cluster-types/serverless.adoc (1)
97-99: Split the combined RBAC/mTLS bullet for scanability.Two separate bullets read better and make it easier to link to specific docs (RBAC in DP). The reordering of Kafka Connect looks fine.
Please confirm with PM/ENG that both “RBAC in the data plane” and “mTLS for Kafka API clients” remain unsupported for Serverless as of August 28, 2025.
Apply:
-* RBAC in the data plane and mTLS authentication for Kafka API clients +* RBAC in the data plane +* mTLS authentication for Kafka API clients * Kafka ConnectOptionally add a cross-link for RBAC in DP:
-* RBAC in the data plane +* xref:security:authorization/rbac/rbac_dp.adoc[RBAC in the data plane]modules/get-started/pages/cloud-overview.adoc (2)
175-177: Link the new RBAC-in-DP bullet to the RBAC DP doc.This improves discoverability and aligns terminology with the Serverless page.
Apply:
-* Role-based access control (RBAC) in the data plane +* xref:security:authorization/rbac/rbac_dp.adoc[Role-based access control (RBAC) in the data plane]
76-80: Avoid conflation between “RBAC & audit logs” row and “RBAC in the data plane.”The table row is broader (“RBAC & audit logs”), while the new bullet below is specific to data-plane RBAC. Consider clarifying the row label or adding a footnote to indicate that “RBAC” here includes data-plane RBAC and audit logs, which are not available on Serverless.
Apply (one option):
-| *RBAC & audit logs* +| *RBAC (data plane) & audit logs*Or add a short note below the table clarifying scope.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
modules/get-started/pages/cloud-overview.adoc(1 hunks)modules/get-started/pages/cluster-types/serverless.adoc(1 hunks)modules/security/pages/authorization/rbac/rbac_dp.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - rp-cloud
- GitHub Check: Header rules - rp-cloud
- GitHub Check: Pages changed - rp-cloud
| RBAC in the data plane is available for BYOC and Dedicated clusters. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Clarify Serverless non-support inline and add a cross-reference.
Add an explicit “not supported for Serverless” mention here to remove ambiguity and point readers to the Serverless page. Also remove the trailing space at the end of Line 6.
Apply:
-RBAC in the data plane is available for BYOC and Dedicated clusters.
+RBAC in the data plane is available for BYOC and Dedicated clusters. It is not available for Serverless clusters.
+
+For feature comparisons, see xref:get-started:cloud-overview.adoc#serverless-vs-byoc-dedicated[Serverless vs BYOC/Dedicated].📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| RBAC in the data plane is available for BYOC and Dedicated clusters. | |
| RBAC in the data plane is available for BYOC and Dedicated clusters. It is not available for Serverless clusters. | |
| For feature comparisons, see xref:get-started:cloud-overview.adoc#serverless-vs-byoc-dedicated[Serverless vs BYOC/Dedicated]. |
Feediver1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
This pull request clarifies the availability of role-based access control (RBAC) in the data plane for Serverless.
modules/security/pages/authorization/rbac/rbac_dp.adoc.modules/get-started/pages/cloud-overview.adocto include RBAC in the data plane.modules/get-started/pages/cluster-types/serverless.adoc, ensuring RBAC and mTLS authentication are listed, and adjusted the placement of Kafka Connect for consistency.Resolves https://redpandadata.atlassian.net/browse/DOC-1646
Review deadline:
Page previews
Cloud Overview
RBAC in the Data Plane
Checks