Skip to content

Conversation

@micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Aug 28, 2025

Description

This pull request clarifies the availability of role-based access control (RBAC) in the data plane for Serverless.

  • Added explicit mention that RBAC in the data plane is available for BYOC and Dedicated clusters in modules/security/pages/authorization/rbac/rbac_dp.adoc.
  • Updated the feature list for BYOC and Dedicated clusters in modules/get-started/pages/cloud-overview.adoc to include RBAC in the data plane.
  • Clarified and reordered features for Serverless clusters in modules/get-started/pages/cluster-types/serverless.adoc, ensuring RBAC and mTLS authentication are listed, and adjusted the placement of Kafka Connect for consistency.

Resolves https://redpandadata.atlassian.net/browse/DOC-1646
Review deadline:

Page previews

Cloud Overview
RBAC in the Data Plane

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner August 28, 2025 00:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

📝 Walkthrough

Walkthrough

Documentation updates only:

  • Added “Role-based access control (RBAC) in the data plane” to the Serverless vs BYOC/Dedicated feature list in cloud-overview.adoc.
  • On the Serverless page, reordered the “Kafka Connect” unsupported feature to follow the existing “RBAC in the data plane and mTLS authentication for Kafka API clients” item.
  • In RBAC docs, added a sentence clarifying RBAC in the data plane is available for BYOC and Dedicated clusters, with a minor formatting newline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective Addressed Explanation
Note that RBAC in the data plane is not supported for Serverless, and update the relevant pages (DOC-1646)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Reordered “Kafka Connect” position within the Serverless unsupported features list (modules/cluster-types/serverless.adoc) The issue targets documenting Serverless lack of RBAC in the data plane; reordering Kafka Connect is unrelated to that objective.

Possibly related PRs

Suggested reviewers

  • paulohtb6
  • c4milo
  • sago2k8

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch DOC-1646-RBAC-in-DP-not-supported-for-Serverless

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 9126cd4
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/68afa67bd6ccff000876355c
😎 Deploy Preview https://deploy-preview-403--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
modules/get-started/pages/cluster-types/serverless.adoc (1)

97-99: Split the combined RBAC/mTLS bullet for scanability.

Two separate bullets read better and make it easier to link to specific docs (RBAC in DP). The reordering of Kafka Connect looks fine.

Please confirm with PM/ENG that both “RBAC in the data plane” and “mTLS for Kafka API clients” remain unsupported for Serverless as of August 28, 2025.

Apply:

-* RBAC in the data plane and mTLS authentication for Kafka API clients
+* RBAC in the data plane
+* mTLS authentication for Kafka API clients
 * Kafka Connect 

Optionally add a cross-link for RBAC in DP:

-* RBAC in the data plane
+* xref:security:authorization/rbac/rbac_dp.adoc[RBAC in the data plane]
modules/get-started/pages/cloud-overview.adoc (2)

175-177: Link the new RBAC-in-DP bullet to the RBAC DP doc.

This improves discoverability and aligns terminology with the Serverless page.

Apply:

-* Role-based access control (RBAC) in the data plane
+* xref:security:authorization/rbac/rbac_dp.adoc[Role-based access control (RBAC) in the data plane]

76-80: Avoid conflation between “RBAC & audit logs” row and “RBAC in the data plane.”

The table row is broader (“RBAC & audit logs”), while the new bullet below is specific to data-plane RBAC. Consider clarifying the row label or adding a footnote to indicate that “RBAC” here includes data-plane RBAC and audit logs, which are not available on Serverless.

Apply (one option):

-| *RBAC & audit logs*
+| *RBAC (data plane) & audit logs*

Or add a short note below the table clarifying scope.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 04dc080 and 9126cd4.

📒 Files selected for processing (3)
  • modules/get-started/pages/cloud-overview.adoc (1 hunks)
  • modules/get-started/pages/cluster-types/serverless.adoc (1 hunks)
  • modules/security/pages/authorization/rbac/rbac_dp.adoc (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - rp-cloud
  • GitHub Check: Header rules - rp-cloud
  • GitHub Check: Pages changed - rp-cloud

Comment on lines +6 to +7
RBAC in the data plane is available for BYOC and Dedicated clusters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Clarify Serverless non-support inline and add a cross-reference.

Add an explicit “not supported for Serverless” mention here to remove ambiguity and point readers to the Serverless page. Also remove the trailing space at the end of Line 6.

Apply:

-RBAC in the data plane is available for BYOC and Dedicated clusters. 
+RBAC in the data plane is available for BYOC and Dedicated clusters. It is not available for Serverless clusters.
+
+For feature comparisons, see xref:get-started:cloud-overview.adoc#serverless-vs-byoc-dedicated[Serverless vs BYOC/Dedicated].
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
RBAC in the data plane is available for BYOC and Dedicated clusters.
RBAC in the data plane is available for BYOC and Dedicated clusters. It is not available for Serverless clusters.
For feature comparisons, see xref:get-started:cloud-overview.adoc#serverless-vs-byoc-dedicated[Serverless vs BYOC/Dedicated].

Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@micheleRP micheleRP merged commit 16edd80 into main Aug 28, 2025
5 checks passed
@micheleRP micheleRP deleted the DOC-1646-RBAC-in-DP-not-supported-for-Serverless branch August 28, 2025 01:19
@coderabbitai coderabbitai bot mentioned this pull request Oct 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants