Skip to content

Commit

Permalink
Add fullScreenAspectRatio to copyWidth function (jhomlala#299)
Browse files Browse the repository at this point in the history
* Add fullScreenAspectRatio to copyWidth function

Looks like fullScreenAspectRatio is unused in this function IIUC the intention is to copy it.

This feature does not seem to work when I tested on device. This could possibly be the issue.

* Update better_player_configuration.dart

Fix formatting
  • Loading branch information
njlawton authored Feb 14, 2021
1 parent ce0a014 commit ea7a97f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/src/configuration/better_player_configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ class BetterPlayerConfiguration {
overlay: overlay ?? this.overlay,
errorBuilder: errorBuilder ?? this.errorBuilder,
allowedScreenSleep: allowedScreenSleep ?? this.allowedScreenSleep,
fullScreenAspectRatio:
fullScreenAspectRatio ?? this.fullScreenAspectRatio,
deviceOrientationsOnFullScreen:
deviceOrientationsOnFullScreen ?? this.deviceOrientationsOnFullScreen,
systemOverlaysAfterFullScreen:
Expand Down

0 comments on commit ea7a97f

Please sign in to comment.