Repository navigation
Add laion-img-emb-768-1G-cosine to datasets - #6
Merged
Merged
Conversation
filipecosta90
approved these changes
Jul 12, 2024
filipecosta90
approved these changes
Sep 24, 2024
fcostaoliveira
added a commit
that referenced
this pull request
Jul 20, 2026
… in duration mode (#152) Reliability fixes from the full Redis-vs-Vertex end-to-end run (issue #151), the localized/validatable subset: - #3 `--engines-file` was a silent no-op: `read_engine_configs()` globbed `experiments/configurations/*.json` and ignored the flag, so `--engines-file x.json --engines my-cfg` failed with a confusing "no engines match". Now `read_engine_configs(engines_file)` reads ONLY that file when given; a missing/malformed file is a hard error, not a fall-through. Verified end-to-end (the file's config runs) + unit-tested. - #1 Vertex stream-update upload treated a transient HTTP 401 as fatal, aborting mid-stream and leaving a partially-populated index that returns silently-wrong recall. Now a 401 re-mints the access token and retries the (idempotent) batch (bounded, same shape as the existing 429/Retry-After handling). This plus the existing per-worker 45-min proactive refresh covers #2 (token expiry) for the long-upload path. - #6 `--repetitions` (default 3, best-of-N) is meaningless in --search-duration timed mode — it just triples runtime for an upward-biased max. Force 1 there, warning if the user set >1. Deferred (own PRs, noted on the issue): #4 Redis M×EFC index-name collision (tests hardcode "idx"; needs Redis/Valkey/Dragonfly validation), #5 per-search watchdog, #7 Vertex indexSyncTime wait, #8 streaming percentiles. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@filipecosta90