Update old links for modules-api-ref.md #13479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to be merged, as it affects module API doc updates. |
|
@oranagra and @yossigo Would one of you approve and merge this PR? It contains changes to several links that appear in the modules API docs when the utils/generate-module-api-doc.rb is run. This is needed by the automation @paoloredis put in place to automatically update commands.json content when a new GA release is tagged. Thank you! |
oranagra
approved these changes
Nov 4, 2024
| @@ -478,7 +478,7 @@ static int __redisGetSubscribeCallback(redisAsyncContext *ac, redisReply *reply, | |||
|
|
|||
| /* Match reply with the expected format of a pushed message. | |||
| * The type and number of elements (3 to 4) are specified at: | |||
| * https://redis.io/topics/pubsub#format-of-pushed-messages */ | |||
| * https://redis.io/docs/latest/develop/interact/pubsub/#format-of-pushed-messages */ | |||
There was a problem hiding this comment.
in theory, this should be made in the upstream hiredis repo and pulled form there.
but i don't think it's an issue to change it here first / too
YaacovHazan
pushed a commit
that referenced
this pull request
Jan 14, 2025
This PR replaces old .../topics/... links with current links, specifically for the modules-api-ref.md file and the new automation that Paolo Lazzari is working on. A few of the topics links have redirects, but some don't. Best to use updated links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces old .../topics/... links with current links, specifically for the modules-api-ref.md file and the new automation that Paolo Lazzari is working on. A few of the topics links have redirects, but some don't. Best to use updated links.