WAITAOF: Update fsynced_reploff_pending just before starting the initial AOFRW fork #12620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set
fsynced_reploff_pending
instartAppendOnly
, and the fork doesn't start immediately (e.g. there's another fork active at the time), any subsequent commands will incrementserver.master_repl_offset
, but will not cause a fsync (given they were executed before the fork started, they just ended up in the RDB part of it)Therefore, any WAITAOF will wait on the new master_repl_offset, but it will time out because no fsync will be executed.
Release notes: