Fixes flaky text word weights #416
Merged
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-cechmanek
requested review from
abrookins,
Copilot and
tylerhutcherson
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flakiness in the test_text_query_word_weights test by making the test results more deterministic. The test now uses smaller weights that don't affect result ordering and adds explicit sorting to ensure consistent ordering.
- Uses smaller weight values (1.1 and 1.15 instead of 3.4 and 5) to avoid changing result order
- Adds
sort_by="description"parameter to both queries for deterministic ordering - Simplifies assertions to compare descriptions directly and check score changes when weighted terms are present
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.