docs(#373): verify sortBy already implemented for VectorQuery and Vec… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torRangeQuery Issue #373 requested adding sortBy support to VectorQuery and VectorRangeQuery. Investigation reveals this feature is already fully implemented: Implementation: - VectorQuery: sortBy() and sortDescending() methods (lines 817-831) - VectorRangeQuery: sortBy() and sortDescending() methods (lines 367-381) - SearchIndex.searchWithSort() applies sorting via Jedis (lines 1360-1399) - Sorting parameters properly passed through query execution pipeline Test Coverage: - QuerySortingIntegrationTest with 4 passing tests - testSortVectorQuery: ascending sort verification - testSortVectorQueryDescending: descending sort verification - testSortVectorRangeQuery: range query sorting - testSortFilterQueryAlreadyWorks: baseline comparison Changes: - Removed outdated test comments claiming methods don't exist - No implementation changes needed Tests: 282 passed, 14 skipped (API keys) Closes #373 - feature already complete with full test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…torRangeQuery
Issue #373 requested adding sortBy support to VectorQuery and VectorRangeQuery. Investigation reveals this feature is already fully implemented:
Implementation:
Test Coverage:
Changes:
Tests: 282 passed, 14 skipped (API keys)
Closes #373 - feature already complete with full test coverage