feat: use AbstractPipeline for Redis Cluster compatibility #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of Python RedisVL fix for issue #365. Ensures storage classes use AbstractPipeline instead of Pipeline to support both regular Pipeline and MultiClusterPipeline objects. Changes: - BaseStorage: Changed Pipeline to AbstractPipeline in write() and get() methods, removed unsafe casts to Pipeline - HashStorage: Updated set() and getResponse() signatures to accept AbstractPipeline, updated get() to use AbstractPipeline - JsonStorage: Updated set() and getResponse() signatures to accept AbstractPipeline - EmbeddingsCache: Updated mset(), mget(), and mexists() to use AbstractPipeline - Add AbstractPipelineTest with 4 tests verifying compatibility This ensures compatibility with both standalone Redis and Redis Cluster deployments, matching Python's graceful handling of both Pipeline and ClusterPipeline types via isinstance() checks. In Java/Jedis: - Pipeline extends PipelineBase (deprecated) - MultiClusterPipeline extends PipelineBase - Both extend AbstractPipeline as common base - UnifiedJedis.pipelined() returns AbstractPipeline (may be Pipeline or MultiClusterPipeline depending on provider) Without this fix, code would fail with ClassCastException when using MultiClusterPipeline in cluster deployments.
bsbodden
force-pushed
the
bsb/cluster_pipeline_fix
branch
from
bce035b to
e940ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of Python RedisVL fix for issue #365. Ensures storage classes use AbstractPipeline instead of Pipeline to support both regular Pipeline and MultiClusterPipeline objects.
Changes:
This ensures compatibility with both standalone Redis and Redis Cluster deployments, matching Python's graceful handling of both Pipeline and ClusterPipeline types via isinstance() checks.
In Java/Jedis:
Without this fix, code would fail with ClassCastException when using MultiClusterPipeline in cluster deployments.