Sentinel connection pool discarding is_master flag on reset #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- is_master is not passed through when recreating the ConnectionPool. - This was causing unexpected behaviour where we would specifiy that we wish to connect to the slave, but the master would be read from instead.
jonathanfrawley
changed the title
andymccurdy
added a commit
that referenced
this pull request
Sep 18, 2014
Sentinel connection pool discarding is_master flag on reset
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When resetting a sentinel connection pool which is set to point at the slaves, it resets to point at the master every time as the is_master flag is not passed into the constructor on reset.
Solution:
Pass the is_master flag through on reset, which will attempt to reconnect to the master or slave depending on what the programmer originally asked for.
Risk:
No real risk here as the client will connect to the master if no slaves are available. The desired behaviour is that the connection pool retains the knowledge that it should be connected to a master or a slave. We have been using this change in production for 2 weeks with no problems.