Skip to content

Conversation

@peperon
Copy link
Member

@peperon peperon commented Nov 3, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

I’m adding the **options argument to the sentinel parsers to prevent an exception that occurs when they’re called using self.response_callbacks[command_name](response, **options):

Traceback (most recent call last):
  File "/home/user/test-redispy/testbug.py", line 13, in <module>
    print(conn.sentinel_master("mymaster"))
  File "/usr/lib/python3.10/site-packages/redis/commands/sentinel.py", line 31, in sentinel_master
    return self.execute_command(
  File "/usr/lib/python3.10/site-packages/redis/client.py", line 621, in execute_command
    return self._execute_command(*args, **options)
  File "/usr/lib/python3.10/site-packages/redis/client.py", line 632, in _execute_command
    return conn.retry.call_with_retry(
  File "/usr/lib/python3.10/site-packages/redis/retry.py", line 105, in call_with_retry
    return do()
  File "/usr/lib/python3.10/site-packages/redis/client.py", line 633, in <lambda>
    lambda: self._send_command_parse_response(
  File "/usr/lib/python3.10/site-packages/redis/client.py", line 604, in _send_command_parse_response
    return self.parse_response(conn, command_name, **options)
  File "/usr/lib/python3.10/site-packages/redis/client.py", line 664, in parse_response
    return self.response_callbacks[command_name](response, **options)
TypeError: parse_sentinel_master() got an unexpected keyword argument 'return_responses'

The issue is described in more details here

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@petyaslavova petyaslavova merged commit 6b848e1 into redis:master Nov 3, 2025
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants