Skip to content

Change 'zrange' args type hints - adding Optional type hint for args that can be None #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Change 'zrange' args type hints - adding Optional type hint for args that can be None #3610

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4255e10
fix(redis-client): change `zrange` num parameter type to `Optional[int]`
kesha1225 Apr 19, 2025
393f260
add changes
kesha1225 Apr 19, 2025
54f3573
fix(redis-client): normalize optional parameter annotations
kesha1225 Apr 22, 2025
fc88d6f
Merge branch 'master' into fix-type
petyaslavova Apr 24, 2025
339d180
commit message: fix(redis-client): normalize optional parameter annot…
kesha1225 Apr 22, 2025
8df197c
fix(redis-client): replace Optional[None] with Optional[int] for nume…
kesha1225 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,3 +1146,4 @@ incompatible in code using*SCAN commands loops such as
* Implemented STRLEN
* Implemented PERSIST
* Implemented SETRANGE
* Changed type annotation of the `num` parameter in `zrange` from `int` to `Optional[int]
2 changes: 1 addition & 1 deletion redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4458,7 +4458,7 @@ def zrange(
byscore: bool = False,
bylex: bool = False,
offset: int = None,
num: int = None,
num: Optional[int] = None,
) -> ResponseT:
"""
Return a range of values from sorted set ``name`` between
Expand Down
Loading