Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format connection errors in the same way everywhere #3305

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Format connection errors in the same way everywhere #3305

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4ac10c
Format connection errors in the same way everywhere
gerzse Jul 3, 2024
47df571
Also cover the async test
gerzse Jul 4, 2024
359a1a5
Stabilize async test
gerzse Jul 4, 2024
bf189fc
Stabilize async test
gerzse Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stabilize async test
  • Loading branch information
@gerzse
gerzse committed Jul 4, 2024
commit 359a1a5e815e221c6d2b384880366b323c132893
4 changes: 2 additions & 2 deletions tests/test_asyncio/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,10 +533,10 @@ async def test_format_error_message(conn, error, expected_message):

async def test_network_connection_failure():
with pytest.raises(ConnectionError) as e:
redis = Redis(port=9999)
redis = Redis(host='127.0.0.1', port=9999)
await redis.set("a", "b")
assert (
str(e.value) == "Error 111 connecting to localhost:9999. "
str(e.value) == "Error 111 connecting to 127.0.0.1:9999. "
"Connect call failed ('127.0.0.1', 9999)."
)

Expand Down
Loading