Make it possible to customize SSL ciphers #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerzse
force-pushed
the
5.0.x/custom-ssl-ciphers
branch
from
adfabbd to
3a9a6a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #3212 +/- ##
==========================================
+ Coverage 90.64% 91.83% +1.18%
==========================================
Files 126 126
Lines 32229 32782 +553
==========================================
+ Hits 29215 30104 +889
+ Misses 3014 2678 -336 ☔ View full report in Codecov by Sentry. |
gerzse
force-pushed
the
5.0.x/custom-ssl-ciphers
branch
from
8e38a8a to
3a9a6a7
Compare
Given that Python 3.10 changed the default list of SSL ciphers, it is a good idea in general to allow customization of the list of cyphers when using Redis with TLS. It seems that this works only with TLS 1.2, and with TLS 1.3 it's intentionally not possible to change the ciphers: https://docs.python.org/3/library/ssl.html#ssl.SSLContext.set_ciphers
gerzse
force-pushed
the
5.0.x/custom-ssl-ciphers
branch
from
052c316 to
159802e
Compare
gerzse
added a commit
to gerzse/redis-py
that referenced
this pull request
Apr 23, 2024
Given that Python 3.10 changed the default list of TLS ciphers, it is a good idea to allow customization of the list of ciphers when using Redis with TLS. In some situations the client is unusable right now with older servers and Python >= 3.10.
dvora-h
pushed a commit
that referenced
this pull request
May 8, 2024
Given that Python 3.10 changed the default list of TLS ciphers, it is a good idea to allow customization of the list of ciphers when using Redis with TLS. In some situations the client is unusable right now with older servers and Python >= 3.10.
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Given that Python 3.10 changed the default list of TLS ciphers, it is a good idea to allow customization of the list of ciphers when using Redis with TLS. In some situations the client is unusable right now with older servers and Python >= 3.10.
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Given that Python 3.10 changed the default list of TLS ciphers, it is a good idea to allow customization of the list of ciphers when using Redis with TLS. In some situations the client is unusable right now with older servers and Python >= 3.10.
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Given that Python 3.10 changed the default list of TLS ciphers, it is a good idea to allow customization of the list of ciphers when using Redis with TLS. In some situations the client is unusable right now with older servers and Python >= 3.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Given that Python 3.10 changed the default list of SSL ciphers, it is a good idea in general to allow customization of the list of cyphers when using Redis with TLS.
It seems that this works only with TLS 1.2, and with TLS 1.3 it's intentionally not possible to change the ciphers:
https://docs.python.org/3/library/ssl.html#ssl.SSLContext.set_ciphers