Skip to content

Optionally disable disconnects in read_response #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2023
+149 −110
Merged

Optionally disable disconnects in read_response #2695

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1d5a9b
Add regression tests and fixes for issue #1128
kristjanvalur Dec 12, 2022
7c2e955
Fix tests for resumable read_response to use "disconnect_on_error"
kristjanvalur Jan 5, 2023
087d994
undo prevision fix attempts in async client and cluster
kristjanvalur Apr 5, 2023
18bc9ed
re-enable cluster test
kristjanvalur May 7, 2023
5437f7a
Suggestions from code review
kristjanvalur May 3, 2023
b9d05e4
Add CHANGES
kristjanvalur Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests for resumable read_response to use "disconnect_on_error"
  • Loading branch information
@kristjanvalur
kristjanvalur committed May 7, 2023
commit 7c2e955eeef4932b99db6ceaf9224f1c834cfcdd
2 changes: 1 addition & 1 deletion tests/test_asyncio/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ async def test_connection_parse_response_resume(r: redis.Redis):
conn._parser._stream = MockStream(message, interrupt_every=2)
for i in range(100):
try:
response = await conn.read_response()
response = await conn.read_response(disconnect_on_error=False)
break
except MockStream.TestError:
pass
Expand Down
2 changes: 1 addition & 1 deletion tests/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def test_connection_parse_response_resume(r: redis.Redis, parser_class):
conn._parser._sock = mock_socket
for i in range(100):
try:
response = conn.read_response()
response = conn.read_response(disconnect_on_error=False)
break
except MockSocket.TestError:
pass
Expand Down