Skip to content

Fix warnings and resource usage problems in asyncio unittests #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 26, 2022
Merged

Fix warnings and resource usage problems in asyncio unittests #2258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3b01dbd
Use pytest-asyncio in auto mode
kristjanvalur Jun 28, 2022
451ac03
Use "Factories as Fixtures" test pattern for the `create_redis` fixture
kristjanvalur Jun 28, 2022
1a1c0d7
Fix sporadic error on fast event loops, such as `--uvloop`
kristjanvalur Jun 28, 2022
56bc4a1
Close connection, even if "username" was in kwargs
kristjanvalur Jun 28, 2022
8d26c91
Do async cleanup of acl passwords via a fixture
kristjanvalur Jun 28, 2022
ea68f78
Remove unused import, fix whitespace
kristjanvalur Jun 28, 2022
c745185
Fix test with missing "await"
kristjanvalur Jun 28, 2022
a69d73a
Close pubsub objects after use in unittest
kristjanvalur Jun 28, 2022
f2c100c
re-introduce `pytestmark=pytest.mark.asyncio` for python 3.6
kristjanvalur Jun 28, 2022
d7ca47f
Use context manager to clean up connections in connection pool for un…
kristjanvalur Jun 28, 2022
011b76b
Provide asynccontextmanager for python 3.6
kristjanvalur Jun 28, 2022
7b6a03c
make `test_late_subscribe()` more robuste
kristjanvalur Jun 29, 2022
f48c733
Catch a couple of additional leaked resources
kristjanvalur Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused import, fix whitespace
  • Loading branch information
@kristjanvalur
kristjanvalur committed Jul 25, 2022
commit ea68f788840a1a78077b1ec52eeaaaa9be3da7a8
1 change: 0 additions & 1 deletion tests/test_asyncio/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import asyncio
import random
import sys
from typing import Union
Expand Down
2 changes: 1 addition & 1 deletion tests/test_asyncio/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def factory(username):
yield factory
for username in usernames:
await r.acl_deluser(username)


@pytest_asyncio.fixture()
async def slowlog(r: redis.Redis):
Expand Down