-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix XAUTOCLAIM
to return the full response
#2252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2252 +/- ##
===========================================
- Coverage 91.83% 76.98% -14.85%
===========================================
Files 108 108
Lines 27690 26913 -777
===========================================
- Hits 25429 20720 -4709
- Misses 2261 6193 +3932
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super tiny + clean. Nice!
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog. This PR handles the new XAUTOCLAIM response format in a backwards-compatible way. Closes replicate#671
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog. This PR handles the new XAUTOCLAIM response format in a backwards-compatible way. Closes replicate#671 Signed-off-by: andreasjansson <andreas@replicate.ai>
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog. This PR handles the new XAUTOCLAIM response format in a backwards-compatible way. Closes #671 Signed-off-by: andreasjansson <andreas@replicate.ai>
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog. This PR handles the new XAUTOCLAIM response format in a backwards-compatible way. Closes replicate/cog#671 Signed-off-by: andreasjansson <andreas@replicate.ai>
[A breaking change](redis/redis-py#2252) in `redis==4.3.4` breaks Cog. This PR handles the new XAUTOCLAIM response format in a backwards-compatible way. Closes replicate/cog#671 Signed-off-by: andreasjansson <andreas@replicate.ai>
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes #2226