Correct retention_msecs value #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `retention_msecs` takes a millisecond value not a seconds value, having checked and tested redis/commands/timeseries/commands.py is not adjusting seconds to milliseconds it is passing it through as is, therefore the statement in this doc is incorrect as it creates a time series with a retention period of 5 milliseconds not 5 seconds as stated.
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
==========================================
+ Coverage 91.83% 91.84% +0.01%
==========================================
Files 108 108
Lines 27690 27690
==========================================
+ Hits 25429 25432 +3
+ Misses 2261 2258 -3
Continue to review full report at Codecov.
|
dvora-h
approved these changes
Jun 19, 2022
Collaborator
|
@earthgecko Thank you for helping make our documentation better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
retention_msecstakes a millisecond value not a seconds value, having checked and tested redis/commands/timeseries/commands.py is not adjusting seconds to milliseconds it is passing it through as is, therefore the statement in this doc is incorrect as it creates a time series with a retention period of 5 milliseconds not 5 seconds as stated.