Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #2160

Merged
merged 1 commit into from
May 2, 2022
Merged

Build improvements #2160

merged 1 commit into from
May 2, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented May 2, 2022

Given that the CI runs of 3.11 cannot be exluded from the PR request list, it is effectively useless.

Once this issue actions/runner#2347 is resolved, we can re-enable.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Given that the CI runs of 3.11 cannot be exluded from the PR request list, it is effectively useless.

Once this issue https://github.com/actions/toolkit/issues/399 is resolved, we can re-enable.
@chayim chayim requested a review from dvora-h May 2, 2022 09:01
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #2160 (714aa46) into master (40fdb15) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
- Coverage   92.50%   92.49%   -0.02%     
==========================================
  Files         105      105              
  Lines       25191    25191              
==========================================
- Hits        23303    23300       -3     
- Misses       1888     1891       +3     
Impacted Files Coverage Δ
tests/test_cluster.py 97.36% <0.00%> (-0.12%) ⬇️
redis/asyncio/connection.py 84.72% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fdb15...714aa46. Read the comment docs.

@dvora-h dvora-h merged commit 25cb4cb into redis:master May 2, 2022
@chayim chayim deleted the ck-cache-bye-311 branch March 26, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants