Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'update_supported_erros' to 'update_supported_errors' in Retry module #2144

Merged
merged 1 commit into from
May 2, 2022

Conversation

Ankhas
Copy link
Contributor

@Ankhas Ankhas commented Apr 27, 2022

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

In the Retry module, a function was named update_supported_erros. I rename it to update_supported_errors

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #2144 (e8defb7) into master (6ba4641) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2144      +/-   ##
==========================================
+ Coverage   92.44%   92.46%   +0.02%     
==========================================
  Files         104      104              
  Lines       24385    24385              
==========================================
+ Hits        22542    22547       +5     
+ Misses       1843     1838       -5     
Impacted Files Coverage Δ
redis/connection.py 86.53% <100.00%> (ø)
redis/retry.py 100.00% <100.00%> (ø)
redis/asyncio/connection.py 84.83% <0.00%> (+0.11%) ⬆️
tests/test_cluster.py 97.60% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba4641...e8defb7. Read the comment docs.

@chayim chayim added the bug Bug label May 2, 2022
@chayim
Copy link
Contributor

chayim commented May 2, 2022

Thank you for fixing this!

@chayim chayim self-requested a review May 2, 2022 09:03
@chayim chayim merged commit eea88da into redis:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants