Implement/test LOLWUT command #1448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://redis.io/commands/lolwut This is a lot of fun to play with: ```python >>> from redis import Redis >>> redis = Redis() >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⣴⣶⣶⣶⣶⡆ ⣿⣿⣿⣿⣿⡇ ⠹⡿⠟⣿⡿⠃ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⢰⣶⣶⣶⣶⡆ ⢿⣿⣿⣿⣿⠁ ⠸⡿⢿⠿⡿⠃ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⢰⣶⣶⣶⣶⡆ ⣸⣿⣿⣻⣿⡅ ⠿⡿⠻⠿⠿⠁ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> ```
|
LOL, this one is interesting. Might be not useful in real project tho. |
|
@andymccurdy - I'm not sure if a documentation update is warranted for this change. What do you think? If you'd like for this to be documented, where should I document it? Any tips? Thanks! |
command is always a list. If index 3 is not a list, assume Redis Enterprise and return index 4 instead
Co-authored-by: Andy McCurdy <andy@andymccurdy.com>
* getex * flake8 fix * comments
* hrandfield * use mapping in hset * skip if version not fit * remove empty line * flake8 comments * new line for each comment
Co-authored-by: malinaa96 <52569986+malinaa96@users.noreply.github.com> Co-authored-by: Avital Fine <79420960+AvitalFineRedis@users.noreply.github.com>
Small typo in documentation
* zinter * change options in _zaggregate * skip for previous versions * flake8 * validate the aggregate value * invalid aggregation * invalid aggregation * change options to get Co-authored-by: Chayim <chayim@users.noreply.github.com>
* exclusive gt and lt in zadd * docs update
brainix
added a commit
to brainix/pottery
that referenced
this pull request
Aug 28, 2021
1. `LOLWUT` command: https://redis.io/commands/lolwut 2. PR upstream: redis/redis-py#1448
* Merged new sentinel commands from redis#835 Thanks you @otherpirate for the contribution! * Added an execute wrapper and tests. The tests ensure that the function is called. Nothing more since we do not currently have enough testing support for sentinel
* MINID and LIMIT
* redis#1434 Added zmscore command support * redis#1434 Fixed typo and doc * redis#1434 Set [] as default value for members arg in zmscore func * redis#1434 Set None as default value for members arg in zmscore func * redis#1434 Removed default value for members arg in zmscore func * Fixed flake8 formatting Co-authored-by: jiekun.zhu <jiekun.zhu@shopee.com>
* add support to STRALDO command * add tests * skip if version .. * new line * lower case * fix comments * callback * change to get
* set in unix time * update skip version
bgsave tests Part of redis#1546
Part of redis#1546 commands.
* GEOSEARCH and GEOSEARCHSTORE * negative test * change georadius_generic to geosearch_generic * add documentations to the functions * add docstring to the parser * farest
Adding support for ACL help Part of redis#1546
closes redis#1539 Part of redis#1546
* CLIENT LIST fix to allow multiple client_ids Support for CLIENT KILL with the USER filter Part of redis#1546 * test fix
|
@chayim - Is there any way that I could get this PR merged? Thanks! |
|
Can you merge master in and resolve conflicts. Once it passes all tests, I'd be happy to. |
https://redis.io/commands/lolwut This is a lot of fun to play with: ```python >>> from redis import Redis >>> redis = Redis() >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⣴⣶⣶⣶⣶⡆ ⣿⣿⣿⣿⣿⡇ ⠹⡿⠟⣿⡿⠃ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⢰⣶⣶⣶⣶⡆ ⢿⣿⣿⣿⣿⠁ ⠸⡿⢿⠿⡿⠃ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⢰⣶⣶⣶⣶⡆ ⣸⣿⣿⣻⣿⡅ ⠿⡿⠻⠿⠿⠁ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> ```
|
I made a mess out of this branch. Recreating... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
$ toxpass with this change (including linting)?Description of change
Implement/test
LOLWUTcommandThis is a lot of fun to play with: