Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.3.3 continues to contain backwards incompatible change to redis.lock.Lock #2223

Closed
zzzeek opened this issue Jun 8, 2022 · 0 comments · Fixed by #2254
Closed

v4.3.3 continues to contain backwards incompatible change to redis.lock.Lock #2223

zzzeek opened this issue Jun 8, 2022 · 0 comments · Fixed by #2254
Assignees
Labels
breakingchange API or Breaking Change

Comments

@zzzeek
Copy link

zzzeek commented Jun 8, 2022

Hey this is a continuation of #2209.

The API change made in https://github.com/redis/redis-py/pull/2210/files does not restore backwards compatibility.

We are calling acquire like this:

lock = redis.lock(
    "_lock{0}".format(key),
    timeout=self.lock_timeout,
    sleep=self.lock_sleep,
    thread_local=self.thread_local_lock,
)

lock.acquire(False)

this is broken by fa0be76 which changes the API of lock.acquire() to use kw-only arguments.

since in #2209 it looks like py-redis has the willingness to revert these changes, hoping you can do that here also. otherwise we have a dogpile.cache patch ready to go out to work around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants