Skip to content

v4.3.3 continues to contain backwards incompatible change to redis.lock.Lock #2223

Closed
@zzzeek

Description

@zzzeek

Hey this is a continuation of #2209.

The API change made in https://github.com/redis/redis-py/pull/2210/files does not restore backwards compatibility.

We are calling acquire like this:

lock = redis.lock(
    "_lock{0}".format(key),
    timeout=self.lock_timeout,
    sleep=self.lock_sleep,
    thread_local=self.thread_local_lock,
)

lock.acquire(False)

this is broken by fa0be76 which changes the API of lock.acquire() to use kw-only arguments.

since in #2209 it looks like py-redis has the willingness to revert these changes, hoping you can do that here also. otherwise we have a dogpile.cache patch ready to go out to work around this.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions