-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: release 0.6.0 #99
Conversation
Some comments:
Question: Given the goal set of the JDK + how it works, but more importantly not having any OS specific code in here (other than the demos folder)... why run CI across the platforms? |
On the merge side - once CI passes, and we're merged to master... master should properly publish snapshots to mavenhub. If that happens - we're good to use the drafter. |
Ok, done
The issue is that windows and mac do not provide docker out of the box, so for now I remove CI on mac and windows and just use Linux
Yeah, I don't see a need to run the long, expensive CI on all platforms, isn't Java build once run anywhere, anyways? :-) |
…generics code (SonarLint java:S2293)
…esponding dedicated assertion (SonarLint java:S5838)
…ed (SonarLint java:S5853)
…arLint java:S1643)
…onarLint java:S5411)
…ompareTo(T obj)" method (SonarLint java:S1210)
…arLint java:S2153)
…in pairs (SonarLint java:S1206)
…ethods (SonarLint java:S1161)
…ent() (SonarLint java:S3655)
…"public" (SonarLint java:S5993)
5aab08b
to
d7fa985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR buttons up the 0.6.0 release. Ups POM versions, apply SonarLint refactoring suggestions: