Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: release 0.6.0 #99

Merged
merged 25 commits into from
Sep 2, 2022
Merged

release: release 0.6.0 #99

merged 25 commits into from
Sep 2, 2022

Conversation

bsbodden
Copy link
Contributor

@bsbodden bsbodden commented Aug 31, 2022

This PR buttons up the 0.6.0 release. Ups POM versions, apply SonarLint refactoring suggestions:

* 358d474 - refactor: clean up the wording on metamodel generator messages
* 4199a64 - ci: update wordlist for spellchecker action
* 92c821c - docs: add Spring Data Redis dependent version to README
* 704834f - refactor: constructors of an "abstract" class should not be declared "public" (SonarLint java:S5993) 
* 0a18374 - fix: second class type in Pair not properly declared in getFirstGetter
* 7ea1a46 - refactor: optional value should only be accessed after calling isPresent() (SonarLint java:S3655)
* 7556c47 - refactor: "@Override" should be used on overriding and implementing methods (SonarLint java:S1161)
* 3bdc48b - refactor: utility classes should not have public constructors (SonarLint java:S1118)
* b79cc9c - refactor: deprecated code should be removed (java:S1133)
* 31370ae - refactor: "equals(Object obj)" and "hashCode()" should be overridden in pairs (SonarLint java:S1206)
* e67a72c - refactor: boxing and unboxing should not be immediately reversed (SonarLint java:S2153)
* b5ba884 - refactor: "equals(Object obj)" should be overridden along with the "compareTo(T obj)" method (SonarLint java:S1210)
* ab26885 - refactor: boxed "Boolean" should be avoided in boolean expressions (SonarLint java:S5411)
* a2e1b19 - refactor: Strings should not be concatenated using '+' in a loop (SonarLint java:S1643)
* 11fa6df - refactor: consecutive AssertJ "assertThat" statements should be chained (SonarLint java:S5853)
* 03015af - refactor: chained AssertJ assertions should be simplified to the corresponding dedicated assertion (SonarLint java:S5838)
* e96d8be - refactor: lambdas should be replaced with method references (SonarLint java:S1612)
* 7baf520 - refactor: use the diamond operator ("<>") to reduce the verbosity of generics code (SonarLint java:S2293)
* d2d0ea1 - refactor: use Collections.emptyList() instead of Collections.EMPTY_LIST
* 1a62802 - refactor: re-order Java modifiers per conventions
* cabbe17 - docs: add contributors list to README
* 801c3af - release: 0.6.0

@bsbodden bsbodden self-assigned this Aug 31, 2022
@bsbodden bsbodden requested a review from sazzad16 August 31, 2022 21:38
sazzad16
sazzad16 previously approved these changes Sep 1, 2022
@chayim
Copy link
Contributor

chayim commented Sep 1, 2022

Some comments:

  1. We're generally removing contributors from READMEs everywhere, as it's a maintenance sink. On the other hand, the release drafter, already includes the contributors on the release. Can you remove from the readme.
  2. CI was broken and not reporting back - I've fixed that - but note that CI now fails.Please have a look@bsbodden

Question: Given the goal set of the JDK + how it works, but more importantly not having any OS specific code in here (other than the demos folder)... why run CI across the platforms?

@chayim
Copy link
Contributor

chayim commented Sep 1, 2022

On the merge side - once CI passes, and we're merged to master... master should properly publish snapshots to mavenhub. If that happens - we're good to use the drafter.

@bsbodden
Copy link
Contributor Author

bsbodden commented Sep 1, 2022

Some comments:

  1. We're generally removing contributors from READMEs everywhere, as it's a maintenance sink. On the other hand, the release drafter, already includes the contributors on the release. Can you remove from the readme.

Ok, done

  1. CI was broken and not reporting back - I've fixed that - but note that CI now fails.Please have a look@bsbodden

The issue is that windows and mac do not provide docker out of the box, so for now I remove CI on mac and windows and just use Linux

Question: Given the goal set of the JDK + how it works, but more importantly not having any OS specific code in here (other than the demos folder)... why run CI across the platforms?

Yeah, I don't see a need to run the long, expensive CI on all platforms, isn't Java build once run anywhere, anyways? :-)

bsbodden and others added 22 commits September 1, 2022 12:47
…esponding dedicated assertion (SonarLint java:S5838)
…ompareTo(T obj)" method (SonarLint java:S1210)
@bsbodden
Copy link
Contributor Author

bsbodden commented Sep 1, 2022

@chayim @sazzad16 the issue is that Docker needs to be added to the workflow. I'll try to do that and let you know.

@bsbodden bsbodden requested review from sazzad16 and guyroyse and removed request for sazzad16 September 1, 2022 22:18
Copy link

@guyroyse guyroyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsbodden bsbodden merged commit 617b93b into redis:main Sep 2, 2022
@bsbodden bsbodden deleted the bsb/release-0.6.0 branch September 2, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants