Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating spellcheck for CI #67

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Integrating spellcheck for CI #67

merged 3 commits into from
Jul 12, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 11, 2022

closes #63

@chayim chayim requested review from bsbodden and sazzad16 July 11, 2022 09:02
sazzad16
sazzad16 requested changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Error: Files in repository contain spelling errors

@bsbodden
Copy link
Contributor

@chayim the report says redis, JSON, and runtime are misspelled - I couldn't find redis with lowercase R in the READMEs other than in code blocks and I assume we can add entries for JSON and runtime to some white-list dictionary.

@bsbodden bsbodden self-assigned this Jul 12, 2022
@bsbodden
Update wordlist.txt
5c28f56 
Added JSON, runtime and Redis
@bsbodden bsbodden requested a review from sazzad16 July 12, 2022 15:33
bsbodden
bsbodden previously approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsbodden
Update wordlist.txt
355581d 
Added "redis" in lowercase
@sazzad16 sazzad16 merged commit 59585ac into main Jul 12, 2022
@sazzad16 sazzad16 deleted the ck-spellcheck branch July 12, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

@bsbodden bsbodden bsbodden left review comments

Assignees

@bsbodden bsbodden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate spell checks into CI for documentation
3 participants
@chayim @bsbodden @sazzad16