Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about search query parameter binding, #341

Closed
HengCC opened this issue Sep 6, 2023 · 3 comments · Fixed by #379
Closed

about search query parameter binding, #341

HengCC opened this issue Sep 6, 2023 · 3 comments · Fixed by #379
Assignees
Labels
bug Something isn't working

Comments

@HengCC
Copy link

HengCC commented Sep 6, 2023

When there is a duplicate parameter binding, it seems to be causing an issue. For example, in a query like this,

 @Query(value = "(@name:$keyword)|(@content:$keyword)")
 Page<xxxx> search(String keyword, Pageable pageable, SearchLanguage searchLanguage);

the generated SQL statement ends up looking something like this:
"FT.SEARCH" "xxxxIdx" "(@name:sso)|(@content:$keyword)" "LANGUAGE" "chinese" "LIMIT" "10" "10"

notice that the second parameter $keyword was not binding correctly

@bsbodden bsbodden self-assigned this Sep 6, 2023
@bsbodden bsbodden added the bug Something isn't working label Sep 6, 2023
justTimTim added a commit to justTimTim/redis-om-spring that referenced this issue Sep 11, 2023
@justTimTim
Copy link
Contributor

justTimTim commented Sep 12, 2023

@bsbodden Hi! Is this bug no longer relevant? I prepared changes, but did not create a merge request

@bsbodden
Copy link
Contributor

@bsbodden Hi! Is this bug no longer relevant? I prepared changes, but did not create a merge request

Oops, I thought your comment above meant is was part of a PR. Sorry re-opening

@bsbodden bsbodden reopened this Sep 12, 2023
justTimTim added a commit to justTimTim/redis-om-spring that referenced this issue Sep 13, 2023
@justTimTim
Copy link
Contributor

no problem) PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants