Skip to content

Changed the way that modules are detected to work with Redis Enterprise #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonprickett
Copy link
Contributor

Using module list to determine whether a module is installed wasn't working with Redis Enterprise, changing it to use the command info command. Closes #73

@simonprickett simonprickett self-assigned this Jan 6, 2022
@simonprickett simonprickett added the bug Something isn't working label Jan 6, 2022
@simonprickett simonprickett marked this pull request as ready for review January 6, 2022 21:14
@simonprickett
Copy link
Contributor Author

@itamarhaber wondering if you'd mind reviewing this PR to Redis OM Python that changes use of module list to determine if JSON and/or Search are installed as this doesn't work on Redis Enterprise. Uses command info ft.search and command info json.get instead, which return [None] if the command doesn't exist. Tested on Redis Enterprise cloud and OSS Redis 6.2.6 with and without Search and JSON installed.

@simonprickett simonprickett merged commit 544a9c0 into main Jan 7, 2022
@simonprickett simonprickett deleted the bugfix/#73-module-list-not-working-on-redis-enterprise branch January 7, 2022 20:02
@itamarhaber
Copy link
Member

Yeah, that's how the rest of us are doing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis.exceptions.ResponseError: unknown command 'module'
2 participants