misleading type annotation in JsonModel #472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's expected to obtain an element that matches the original class, indicating it's a JsonModel makes the type hint ignore the new class it is inheritating currently
|
I'd suggest maintainers of this repository to not accept this pull request. Not only it's incomplete (I don't understand why annotation should be removed only on JsonModel and not on HashModel, for example), but also incorrect (this removes the typing and doesn't solve the issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expected to obtain an element that matches the original class, indicating it's a JsonModel makes the type hint ignore the new class it is inheritating currently