Skip to content

[WIP] Support null values for optional fields #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −2
Open

[WIP] Support null values for optional fields #340

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b74294
support null values for optional fields
wiseaidev Aug 9, 2022
1efdbdf
support null values for optional int, float fields on save method
wiseaidev Aug 9, 2022
3b07e3f
trying a hacky solution
wiseaidev Aug 9, 2022
79cf5bf
resolve conflict
wiseaidev Aug 10, 2022
4791365
mv restore_null_values from_redis
wiseaidev Aug 12, 2022
187ca0c
mv optional_fields after_required_fields
wiseaidev Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
mv optional_fields after_required_fields 
Signed-off-by: wiseaidev <business@wiseai.dev>
  • Loading branch information
@wiseaidev
wiseaidev committed Aug 12, 2022
commit 187ca0c97abf699d6816ae45c40df048e7dccbfc
4 changes: 2 additions & 2 deletions tests/test_hash_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ class Member(BaseHashModel):
last_name: str = Field(index=True)
email: str = Field(index=True)
join_date: datetime.date
height: Optional[int] = None
weight: Optional[float] = None
age: int = Field(index=True, sortable=True)
bio: str = Field(index=True, full_text_search=True)
height: Optional[int] = Field(index=True)
weight: Optional[float] = Field(index=True)

class Meta:
model_key_prefix = "member"
Expand Down