Performance improvement for first - avoids unnecessary pagination. #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first()
was running theft.search
query to get the first item, then also paginating the whole dataset unnecessarily. This PR addresses that by settingexhaust_results=False
wheneverfirst
callsquery.execute()
. This stops the pagination. Closes #218 and adds a test forfirst()
usingHashModel
.