Pydantic v2 Incompatability with `strawberry-graphql`

[XChikuX]

redis-om on version 0.3.0 with pydantic v2 raises this following error.

│ /root/test/.env/lib/python3.10/site-packages/strawberry/schema/schema_converter.py:777 in        │
│ from_type                                                                                        │
│                                                                                                  │
│   774 │   │   elif isinstance(type_, StrawberryObjectDefinition):                                │
│   775 │   │   │   return self.from_object(type_)                                                 │
│   776 │   │   elif isinstance(type_, StrawberryUnion):                                           │
│ ❱ 777 │   │   │   return self.from_union(type_)                                                  │
│   778 │   │   elif isinstance(type_, LazyType):                                                  │
│   779 │   │   │   return self.from_type(type_.resolve_type())                                    │
│   780 │   │   elif compat.is_scalar(                                                             │
│                                                                                                  │
│ ╭────────────────────────────────────────── locals ──────────────────────────────────────────╮   │
│ │  self = <strawberry.schema.schema_converter.GraphQLCoreConverter object at 0x7f0c5dabcd30> │   │
│ │ type_ = <strawberry.union.StrawberryUnion object at 0x7f0c5dadf190>                        │   │
│ ╰────────────────────────────────────────────────────────────────────────────────────────────╯   │
│                                                                                                  │
│ /root/test/.env/lib/python3.10/site-packages/strawberry/schema/schema_converter.py:795 in        │
│ from_union                                                                                       │
│                                                                                                  │
│   792 │   │   │   # TypeVars, Annotations, LazyTypes, etc it can't perfectly detect issues at    │
│   793 │   │   │   # that stage                                                                   │
│   794 │   │   │   if not StrawberryUnion.is_valid_union_type(type_):                             │
│ ❱ 795 │   │   │   │   raise InvalidUnionTypeError(union_name, type_, union_definition=union)     │
│   796 │   │                                                                                      │
│   797 │   │   # Don't reevaluate known types                                                     │
│   798 │   │   if union_name in self.type_map:                                                    │
│                                                                                                  │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │       self = <strawberry.schema.schema_converter.GraphQLCoreConverter object at              │ │
│ │              0x7f0c5dabcd30>                                                                 │ │
│ │      type_ = <class 'str'>                                                                   │ │
│ │      union = <strawberry.union.StrawberryUnion object at 0x7f0c5dadf190>                     │ │
│ │ union_name = "<class 'str'><class 'redis_om.model.model.ExpressionProxy'>"                   │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
InvalidUnionTypeError: Type `str` cannot be used in a GraphQL Union

I see this issue with HashModel JsonModel and EmbeddedJsonModel being used.

If I have an object with redis-om but its not part of the graphql schema then I only get the below warning

Running strawberry on http://0.0.0.0:8000/graphql 🍓
/root/test/.env/lib/python3.10/site-packages/pydantic/_internal/_config.py:334: UserWarning: Valid config keys have changed in V2:
* 'orm_mode' has been renamed to 'from_attributes'
  warnings.warn(message, UserWarning)

Using regular BaseModel from pydantic seems to work fine.

So I've triaged the issue to changes in redis-om

Has there been some kind of Union with str attached to JsonModel and EmbeddedJsonModel? I'd love to be able to resolve this issue.

[slorello89]

RedisModel (parent of JsonModel) has a pk field, which is declared as a Optional[str] but on the Model itself is a Union[str, ExpressionProxy]

[XChikuX]

RedisModel (parent of JsonModel) has a pk field, which is declared as a Optional[str] but on the Model itself is a Union[str, ExpressionProxy]

Is this a change in Pydantic v2 in redis-om 0.3.0. Or is it a regression in strawberry ?

[slorello89]

ExpressionProxy is what redis om uses to capture queries on the model e.g.

class A(JsonModel):
   name: str = Field(index=True)
   
a = await A.find(A.name == 'foo').first()

the type of A.name is an ExpressionProxy even if a.name is a str

I don't think this behavior is any different in v0.3.x vs v0.2.x

[slorello89]

Think this should have been fixed in #626 (if not feel free to reopen)

[XChikuX]

@slorello89 This is potentially a different issue but I get:

  File "/root/backend/app/common.py", line 37, in <module>
    from aredis_om import (
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/__init__.py", line 4, in <module>
    from .model.migrations.migrator import MigrationError, Migrator
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/model/__init__.py", line 2, in <module>
    from .model import (
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/model/model.py", line 2216, in <module>
    class EmbeddedJsonModel(JsonModel, abc.ABC):
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/model/model.py", line 1311, in __new__
    new_class = super().__new__(cls, name, bases, attrs, **kwargs)
  File "pydantic/main.py", line 282, in pydantic.main.ModelMetaclass.__new__
  File "/usr/lib/python3.10/abc.py", line 106, in __new__
    cls = super().__new__(mcls, name, bases, namespace, **kwargs)
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/model/model.py", line 1896, in __init_subclass__
    cls.redisearch_schema()
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/model/model.py", line 1965, in redisearch_schema
    schema_parts = [schema_prefix] + cls.schema_for_fields()
  File "/root/backend/.env/lib/python3.10/site-packages/aredis_om/model/model.py", line 1983, in schema_for_fields
    fields[name] = PydanticFieldInfo.from_annotation(field)
AttributeError: type object 'FieldInfo' has no attribute 'from_annotation'

[slorello89]

hmm @XChikuX - that method should be there. . . what version of pydantic are you using?

[XChikuX]

Latest on v1

1.10.17

@slorello89

[XChikuX]

@slorello89 Shall I open a new issue for this?

[arareko]

Think this should have been fixed in #626 (if not feel free to reopen)

@slorello89 Sorry but I mentioned on my PR that it will likely fix only the warning but not the issue. This will have to be reopened @XChikuX.

[XChikuX]

@slorello89 This needs to be re-opened. Just tried migrating to v2 again. The same issue exists.
I don't think I have permission to re-open from my side.

[faiz95ahmed]

This needs to be reopened, I run into the same issue

pydantic version: 2.10.6
redis-om: 0.3.3