This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Remove extraneous and contradictory Ruby version config#217
Open
CHTJonas wants to merge 2 commits intoredis:masterfrom
Open
Remove extraneous and contradictory Ruby version config#217CHTJonas wants to merge 2 commits intoredis:masterfrom
CHTJonas wants to merge 2 commits intoredis:masterfrom
Conversation
We need the .ruby-version file to be present before we setup the Ruby environment so we need to checkout the repo first. Signed-off-by: Charlie Jonas <charlie@charliejonas.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If merged, this PR would remove some extraneous and contradictory Ruby/RVM/CI version config and standardised on a single
.ruby-versionfile (which is supported by rbenv, RVM and GitHub Actions).I've set the version inside the
.ruby-versionfile to2.6.6which is the latest version in the2.6release series which is what CI was already using.