Skip to content

Enabled CPU pinning on self-contained-coordinator #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Enabled CPU pinning on self-contained-coordinator #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.23"
version = "0.1.24"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
readme = "Readme.md"
Expand Down
1 change: 1 addition & 0 deletions redis_benchmarks_specification/__self_contained_coordinator__/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def create_self_contained_coordinator_args(project_name):
default=MACHINE_CPU_COUNT,
help="Specify how much of the available CPU resources the coordinator can use.",
)
parser.add_argument("--cpuset_start_pos", type=int, default=0)
parser.add_argument(
"--platform-name",
type=str,
Expand Down
9 changes: 8 additions & 1 deletion redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ def main():
stream_id = None
docker_client = docker.from_env()
home = str(Path.home())
cpuset_start_pos = args.cpuset_start_pos
logging.info("Start CPU pinning at position {}".format(cpuset_start_pos))

# TODO: confirm we do have enough cores to run the spec
# availabe_cpus = args.cpu_count
datasink_push_results_redistimeseries = args.datasink_push_results_redistimeseries
Expand Down Expand Up @@ -207,6 +210,7 @@ def main():
profilers_enabled,
profilers_list,
grafana_profile_dashboard,
cpuset_start_pos,
)


Expand Down Expand Up @@ -251,6 +255,7 @@ def self_contained_coordinator_blocking_read(
profilers_enabled,
profilers_list,
grafana_profile_dashboard="",
cpuset_start_pos=0,
):
num_process_streams = 0
num_process_test_suites = 0
Expand Down Expand Up @@ -285,6 +290,7 @@ def self_contained_coordinator_blocking_read(
profilers_enabled,
profilers_list,
grafana_profile_dashboard,
cpuset_start_pos,
)
num_process_streams = num_process_streams + 1
num_process_test_suites = num_process_test_suites + total_test_suite_runs
Expand Down Expand Up @@ -350,6 +356,7 @@ def process_self_contained_coordinator_stream(
profilers_enabled=False,
profilers_list=[],
grafana_profile_dashboard="",
cpuset_start_pos=0,
):
stream_id = "n/a"
overall_result = False
Expand Down Expand Up @@ -416,7 +423,7 @@ def process_self_contained_coordinator_stream(
for topology_spec_name in benchmark_config["redis-topologies"]:
test_result = False
try:
current_cpu_pos = 0
current_cpu_pos = cpuset_start_pos
ceil_db_cpu_limit = extract_db_cpu_limit(
topologies_map, topology_spec_name
)
Expand Down