Skip to content

[fix] Fixed redistimeseries.client error o self-contained-coordinator #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[fix] Fixed redistimeseries.client error o self-contained-coordinator #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.14"
version = "0.1.15"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
readme = "Readme.md"
Expand All @@ -21,6 +21,7 @@ psutil = "^5.8.0"
tox-docker = "^3.0.0"
PyGithub = "^1.55"
GitPython = "^3.1.20"
redistimeseries = "1.4.3"

[tool.poetry.dev-dependencies]
black = "20.8b1"
Expand Down
4 changes: 2 additions & 2 deletions redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import redis
import os
from pathlib import Path
import redistimeseries
from redistimeseries.client import Client
from docker.models.containers import Container

from redisbench_admin.run.common import (
Expand Down Expand Up @@ -127,7 +127,7 @@ def main():
)
)
try:
rts = redistimeseries.client.Client(
rts = Client(
host=args.datasink_redistimeseries_host,
port=args.datasink_redistimeseries_port,
decode_responses=True,
Expand Down
6 changes: 0 additions & 6 deletions utils/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@
GH_TOKEN,
)

import pytest

import pytest

# First party modules


def test_commit_schema_to_stream():
result, reply_fields, error_msg = commit_schema_to_stream(
Expand Down
Binary file modified utils/tests/test_data/dump.rdb
View file
Open in desktop
Binary file not shown.
8 changes: 0 additions & 8 deletions utils/tests/test_self_contained_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,7 @@
from redisbench_admin.utils.remote import get_overall_dashboard_keynames
from redisbench_admin.utils.utils import get_ts_metric_name

from redis_benchmarks_specification.__common__.builder_schema import (
commit_schema_to_stream,
)
from redis_benchmarks_specification.__builder__.builder import (
builder_consumer_group_create,
builder_process_stream,
)
from redis_benchmarks_specification.__common__.env import (
STREAM_KEYNAME_GH_EVENTS_COMMIT,
STREAM_KEYNAME_NEW_BUILD_EVENTS,
)
from redis_benchmarks_specification.__common__.spec import (
Expand Down