Skip to content

[add] Add per test_name sets for visualization: arch, os, branch, deployment_type #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.7"
version = "0.1.8"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>"]
readme = "Readme.md"
Expand All @@ -16,7 +16,7 @@ argparse = "^1.4.0"
Flask-HTTPAuth = "^4.4.0"
PyYAML = "^5.4.1"
docker = "^4.4.4"
redisbench-admin = "^0.4.15"
redisbench-admin = "^0.4.16"
psutil = "^5.8.0"
tox-docker = "^3.0.0"

Expand Down
2 changes: 1 addition & 1 deletion redis_benchmarks_specification/__common__/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
DATASINK_RTS_AUTH = os.getenv("DATASINK_RTS_AUTH", None)
DATASINK_RTS_USER = os.getenv("DATASINK_RTS_USER", None)
DATASINK_RTS_HOST = os.getenv("DATASINK_RTS_HOST", "localhost")
DATASINK_RTS_PORT = os.getenv("DATASINK_RTS_PORT", 6379)
DATASINK_RTS_PORT = int(os.getenv("DATASINK_RTS_PORT", "6379"))

# logging related
VERBOSE = os.getenv("VERBOSE", "1") == "0"
Expand Down
33 changes: 32 additions & 1 deletion utils/tests/test_self_contained_coordinator.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,24 @@ def test_self_contained_coordinator_blocking_read():
build_variant_setname,
testcases_metric_context_path_setname,
testcases_and_metric_context_path_setname,
project_archs_setname,
project_oss_setname,
project_branches_setname,
project_versions_setname,
project_compilers_setname,
) = get_overall_dashboard_keynames(
tf_github_org, tf_github_repo, tf_triggering_env, test_name
tf_github_org,
tf_github_repo,
tf_triggering_env,
build_variant_name,
running_platform,
test_name,
)
assert rts.redis.exists(testcases_setname)
assert rts.redis.exists(running_platforms_setname)
assert rts.redis.exists(build_variant_setname)
assert rts.redis.exists(testcases_and_metric_context_path_setname)
assert rts.redis.exists(testcases_metric_context_path_setname)
assert build_variant_name.encode() in rts.redis.smembers(
build_variant_setname
)
Expand All @@ -179,5 +191,24 @@ def test_self_contained_coordinator_blocking_read():
test_name
]

assert "amd64".encode() in rts.redis.smembers(project_archs_setname)
assert "debian-buster".encode() in rts.redis.smembers(project_oss_setname)
assert "gcc".encode() in rts.redis.smembers(project_compilers_setname)
assert build_variant_name.encode() in rts.redis.smembers(
build_variant_setname
)
assert running_platform.encode() in rts.redis.smembers(
running_platforms_setname
)

assert len(rts.redis.smembers(project_archs_setname)) == 1
assert len(rts.redis.smembers(project_oss_setname)) == 1
assert len(rts.redis.smembers(project_compilers_setname)) == 1
assert len(rts.redis.smembers(build_variant_setname)) == 1
assert len(rts.redis.smembers(running_platforms_setname)) == 1
assert len(rts.redis.smembers(testcases_setname)) == 1
assert len(rts.redis.smembers(project_branches_setname)) == 1
assert len(rts.redis.smembers(project_versions_setname)) == 0

except redis.exceptions.ConnectionError:
pass