Skip to content

Enabled triggering build/benchmarks on forks #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.73"
version = "0.1.75"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
readme = "Readme.md"
Expand Down
2 changes: 2 additions & 0 deletions redis_benchmarks_specification/__cli__/args.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ def spec_cli_args(parser):
default=START_TIME_NOW_UTC,
)
parser.add_argument("--redis_repo", type=str, default=None)
parser.add_argument("--gh_org", type=str, default="redis")
parser.add_argument("--gh_repo", type=str, default="redis")
parser.add_argument("--trigger-unstable-commits", type=bool, default=True)
parser.add_argument(
"--use-tags",
Expand Down
16 changes: 9 additions & 7 deletions redis_benchmarks_specification/__cli__/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,11 @@ def get_repo(args):
if redisDirPath is None:
cleanUp = True
redisDirPath = tempfile.mkdtemp()
remote_url = f"https://github.com/{args.gh_org}/{args.gh_repo}"
logging.info(
"Retrieving redis repo from remote into {}. Using branch {}.".format(
redisDirPath, args.branch
)
)
cmd = "git clone https://github.com/redis/redis {} --branch {}\n".format(
redisDirPath, args.branch
f"Retrieving redis repo from remote {remote_url} into {redisDirPath}. Using branch {args.branch}."
)
cmd = f"git clone {remote_url} {redisDirPath} --branch {args.branch}\n"
process = subprocess.Popen(
"/bin/bash", stdin=subprocess.PIPE, stdout=subprocess.PIPE
)
Expand Down Expand Up @@ -250,7 +247,12 @@ def trigger_tests_cli_command_logic(args, project_name, project_version):
binary_key,
binary_value,
) = get_commit_dict_from_sha(
cdict["git_hash"], "redis", "redis", cdict, True, args.gh_token
cdict["git_hash"],
args.gh_org,
args.gh_repo,
cdict,
True,
args.gh_token,
)
if args.platform:
commit_dict["platform"] = args.platform
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading