Skip to content

added filtering by platform #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2023
Merged

added filtering by platform #238

merged 3 commits into from
Oct 10, 2023

Conversation

slice4e
Copy link
Collaborator

@slice4e slice4e commented Jun 21, 2023

Filipe,

Added filtering by platform, however not sure how to test it, since it depends on the builder...

Could you please take a look?

thanks
Martin

@slice4e slice4e requested a review from filipecosta90 June 21, 2023 20:59
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 41.17% and project coverage change: -0.12 ⚠️

Comparison is base (d9c42fc) 56.71% compared to head (bc567af) 56.60%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   56.71%   56.60%   -0.12%     
==========================================
  Files          24       24              
  Lines        2234     2249      +15     
==========================================
+ Hits         1267     1273       +6     
- Misses        967      976       +9     
Impacted Files Coverage Δ
redis_benchmarks_specification/__cli__/cli.py 71.42% <25.00%> (-1.53%) ⬇️
...tained_coordinator__/self_contained_coordinator.py 57.47% <40.00%> (-0.48%) ⬇️
...is_benchmarks_specification/__builder__/builder.py 70.98% <50.00%> (-0.22%) ⬇️
redis_benchmarks_specification/__cli__/args.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @slice4e

@filipecosta90 filipecosta90 merged commit 3351065 into main Oct 10, 2023
@filipecosta90 filipecosta90 deleted the filter-platform branch October 10, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants