Skip to content

Enabled arch selection on self-contained-coordinator #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.70"
version = "0.1.71"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
readme = "Readme.md"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,7 @@ def create_self_contained_coordinator_args(project_name):
default="{}/defaults.yml".format(SPECS_PATH_TEST_SUITES),
help="specify the defaults file containing spec topologies, common metric extractions,etc...",
)
parser.add_argument(
"--arch", type=str, default="amd64", help="arch to build artifacts"
)
return parser
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@


def extract_build_info_from_streamdata(testDetails):
arch = "amd64"
use_git_timestamp = False
git_timestamp_ms = None
metadata = None
Expand All @@ -29,6 +30,11 @@ def extract_build_info_from_streamdata(testDetails):
build_artifacts_str = "redis-server"
build_image = testDetails[b"build_image"].decode()
run_image = build_image
if b"arch" in testDetails:
arch = testDetails[b"arch"].decode()
logging.info("detected arch info {}.".format(arch))
else:
logging.info("using default arch info {}.".format(arch))
if b"run_image" in testDetails:
run_image = testDetails[b"run_image"].decode()
logging.info("detected run image info {}.".format(run_image))
Expand All @@ -49,4 +55,5 @@ def extract_build_info_from_streamdata(testDetails):
run_image,
use_git_timestamp,
git_timestamp_ms,
arch,
)
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def process_self_contained_coordinator_stream(
run_image,
use_git_timestamp,
git_timestamp_ms,
_,
) = extract_build_info_from_streamdata(testDetails)

overall_result = True
Expand Down
Loading