Skip to content

Aligned lhash* test-files' names with name inside file #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

markovamaria
Copy link
Collaborator

@markovamaria markovamaria commented Apr 11, 2023

There difference in file test with test description and "name" in test's description itself.
Suggest to align tests' names by renaming of files:

$ less memtier_benchmark-1Mkeys-hash-hincrby.yml | grep name
name: memtier_benchmark-1Mkeys-lhash-hincbry
$ less memtier_benchmark-1Mkeys-hash-hexists.yml | grep name
name: memtier_benchmark-1Mkeys-lhash-hexists

Suggested solution - align name in description with file name.

@markovamaria markovamaria self-assigned this Apr 11, 2023
@markovamaria
Copy link
Collaborator Author

Hi @filipecosta90 , please take a look

@filipecosta90
Copy link
Contributor

@markovamaria the name should be hash and not lhash

@markovamaria
Copy link
Collaborator Author

@markovamaria the name should be hash and not lhash

It is fine, I'll rework.

What is correct combination "hincrby" or "hincbry" ?

@markovamaria
Copy link
Collaborator Author

markovamaria commented Apr 12, 2023

@filipecosta90 , I aligned names in description with file name. As result took "hincrby" as correct one. Please let me know if this should be fixed.

@markovamaria
Copy link
Collaborator Author

@filipecosta90 , could you please take a look?

@filipecosta90
Copy link
Contributor

@filipecosta90 , could you please take a look?

Thank you Maria. Approved!

@filipecosta90 filipecosta90 merged commit 2f3434b into main Apr 20, 2023
@filipecosta90 filipecosta90 deleted the lhash_tests_names branch April 20, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants